Skip to content

Commit 1dc1bec

Browse files
authored
Update README.md (#197)
- Change the title because "konflux-ci/buildah" is not a thing anymore (never existed on Github, does exist on quay.io but will no longer receive updates). - Reword the introduction because this repo doesn't even build buildah anymore. - Drop the explanation of the CEL annotation setup, because it isn't accurate anymore. - Drop the mention of the buildah submodule, replace with dockerfile-json (the only remaining submodule). Signed-off-by: Adam Cmiel <acmiel@redhat.com>
1 parent 020978d commit 1dc1bec

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

README.md

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,20 @@
1-
# konflux-ci/buildah
1+
# konflux-ci/buildah-task
22

3-
This is a rebuild of [containers/buildah](https://github.com/containers/buildah) for use in Konflux-CI. Two images are produced by this repository. One is a simple rebuild of `buildah` and is available at [quay.io/konflux-ci/buildah:latest](https://quay.io/konflux-ci/buildah). The other is oriented at customizing the behavior of `buildah` within Tekton tasks and is available at [quay.io/konflux-ci/buildah-task:latest](https://quay.io/konflux-ci/buildah-task).
3+
This is an image that contains the tools and Bash scripts needed for the Konflux buildah task.
4+
It is available at [quay.io/konflux-ci/buildah-task:latest](https://quay.io/konflux-ci/buildah-task).
45

56
## Building artifacts
67

7-
By default, new artifacts will not be built when only the contents of the `.tekton` have changed for push events. These changes will
8-
still be tested for pull request events. If you want to trigger a rebuild of an artifact for push events, you can manually trigger one
9-
as mentioned in the [Konflux documentation](https://konflux-ci.dev/docs/building/rerunning/).
10-
11-
To see when new builds will be triggered for push events, you can look at the `pipelinesascode.tekton.dev/on-cel-expression` annotation
12-
for the specific components. For example, the `buildah-task` component will only be built if there are changes to its Containerfile or
13-
either of the dependencies mentioned.
14-
15-
```yaml
16-
pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" &&
17-
("dockerfile-json".pathChanged() ||
18-
"Containerfile.task".pathChanged() ||
19-
"scripts/**".pathChanged())
20-
```
8+
Konflux triggers builds automatically for push events (if the relevant files change).
9+
To see what files are considered relevant, check the `pipelinesascode.tekton.dev/on-cel-expression`
10+
annotation in the PipelineRun files in `.tekton/`.
2111

2212
## Updating the git submodule
2313

2414
```bash
25-
git init buildah
26-
cd buildah
27-
git checkout main && git pull
15+
git init dockerfile-json
16+
cd dockerfile-json
17+
git checkout dev && git pull
2818
cd ..
2919
```
3020

@@ -48,4 +38,4 @@ While you can find the Snapshot via the Konflux UI, you can also identify the la
4838
```bash
4939
$ kconfig=<path-to-kubeconfig> && for application in $(oc get applications --no-headers=true -o custom-columns=":metadata.name" --kubeconfig=$kconfig); do oc get snapshots -l "pac.test.appstudio.openshift.io/event-type in (push, Push),appstudio.openshift.io/application=${application}" --sort-by=.metadata.creationTimestamp --kubeconfig=$kconfig | tail -1; done | grep buildah-container
5040
buildah-container-xcrf4 20d
51-
```
41+
```

0 commit comments

Comments
 (0)