Capture HTTP errors for Quay GET requests (#274)

Author: mantomas

config/repository_notification_resetter/notification_resetter/reset_notifications.py

@@ -51,14 +51,18 @@ def get_quay_notifications(
         },
     )
 
-    with urlopen(request) as resp:
-        if resp.status != 200:
-            # do not fail the job if we can't fetch notifications
-            # for single repository
-            LOGGER.warning("Failed to fetch notifications for %s/%s", namespace, name)
-            json_data = {}
-        else:
-            json_data = json.loads(resp.read())
+    try:
+        with urlopen(request) as resp:
+            if resp.status != 200:
+                # do not fail the job if we can't fetch notifications
+                # for single repository
+                LOGGER.warning("Failed to fetch notifications for %s/%s", namespace, name)
+                json_data = {}
+            else:
+                json_data = json.loads(resp.read())
+    except HTTPError:
+        LOGGER.warning("Failed to fetch notifications for %s/%s", namespace, name)
+        json_data = {}
 
     return json_data.get("notifications", [])
 

config/repository_notification_resetter/notification_resetter/test_reset_notifications.py

@@ -361,6 +361,50 @@ def test_reset_notification(self, urlopen):
         self.assert_make_post_request(request)
         self.assert_quay_token_included(request)
 
+    @patch.dict(os.environ, {"QUAY_TOKEN": QUAY_TOKEN})
+    @patch("sys.argv", ["reset_notifications", "--namespace", "sample"])
+    @patch("reset_notifications.urlopen")
+    def test_get_notifications_http_error_returns_empty(self, urlopen):
+        """When fetching notifications returns 504 (or any HTTPError), job continues with empty list."""
+        fetch_repos = MagicMock()
+        response = MagicMock()
+        response.status = 200
+        response.read.return_value = json.dumps(
+            {
+                "repositories": [
+                    {"namespace": "sample", "name": "hello-image"},
+                ],
+            }
+        ).encode()
+        fetch_repos.__enter__.return_value = response
+
+        mock_error = HTTPError(
+            url="http://example.com",
+            code=504,
+            msg="Gateway Timeout",
+            hdrs=None,
+            fp=io.BytesIO(b""),
+        )
+
+        urlopen.side_effect = [
+            fetch_repos,
+            mock_error,  # get_quay_notifications raises
+        ]
+
+        with self.assertLogs(LOGGER) as logs:
+            main()
+            run_log = [
+                msg
+                for msg in logs.output
+                if re.search(
+                    r"Failed to fetch notifications for sample/hello-image",
+                    msg,
+                )
+            ]
+            self.assertEqual(1, len(run_log))
+
+        self.assertEqual(2, urlopen.call_count)
+
     @patch("reset_notifications.urlopen")
     def test_handle_image_repos_pagination(self, urlopen):
         first_fetch_rv = MagicMock()