fix(KONFLUX-8344): account for trailing slash in ITS git url

* If an integration test scenario has a trailing slash in git URL,
  account for it when determining it the source repo info should
  be overwritten for needs of PR testing

Signed-off-by: dirgim <kpavic@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Author: dirgim

internal/controller/snapshot/snapshot_adapter.go

@@ -716,7 +716,7 @@ func urlToGitUrl(url string) string {
 	if strings.HasSuffix(url, ".git") {
 		return url
 	}
-	return url + ".git"
+	return strings.TrimSuffix(url, "/") + ".git"
 }
 
 // shouldUpdateIntegrationTestGitResolver checks if the integration test resolver should be updated based on the source repo

internal/controller/snapshot/snapshot_adapter_test.go

@@ -1125,14 +1125,33 @@ var _ = Describe("Snapshot Adapter", Ordered, func() {
 			)
 
 			BeforeEach(func() {
-				hasSnapshotPR.Annotations[gitops.SnapshotGitSourceRepoURLAnnotation] = sourceRepoUrl
+				hasSnapshotPR.Annotations[gitops.PipelineAsCodeGitSourceURLAnnotation] = sourceRepoUrl
 				hasSnapshotPR.Annotations[gitops.PipelineAsCodeSHAAnnotation] = sourceRepoRef
 				hasSnapshotPR.Annotations[gitops.PipelineAsCodeRepoURLAnnotation] = targetRepoUrl
 				hasSnapshotPR.Annotations[gitops.PipelineAsCodeTargetBranchAnnotation] = "main"
 			})
 
 			It("pullrequest source repo reference and URL should be used", func() {
-				pipelineRun, err := adapter.createIntegrationPipelineRun(hasApp, integrationTestScenario, hasSnapshotPR)
+				integrationTestScenarioWithTrailingSlash := integrationTestScenario.DeepCopy()
+				integrationTestScenarioWithTrailingSlash.Spec.ResolverRef = v1beta2.ResolverRef{
+					Resolver: "git",
+					Params: []v1beta2.ResolverParameter{
+						{
+							Name:  "url",
+							Value: targetRepoUrl + "/",
+						},
+						{
+							Name:  "revision",
+							Value: "main",
+						},
+						{
+							Name:  "pathInRepo",
+							Value: "pipelineruns/integration_pipelinerun_pass.yaml",
+						},
+					},
+				}
+
+				pipelineRun, err := adapter.createIntegrationPipelineRun(hasApp, integrationTestScenarioWithTrailingSlash, hasSnapshotPR)
 				Expect(err).ToNot(HaveOccurred())
 				Expect(pipelineRun).ToNot(BeNil())
 
@@ -1142,7 +1161,7 @@ var _ = Describe("Snapshot Adapter", Ordered, func() {
 				for _, param := range pipelineRun.Spec.PipelineRef.Params {
 					if param.Name == tekton.TektonResolverGitParamURL {
 						foundUrl = true
-						Expect(param.Value.StringVal).To(Equal(targetRepoUrl + ".git")) // must have .git suffix
+						Expect(param.Value.StringVal).To(Equal(sourceRepoUrl + ".git")) // must have .git suffix
 					}
 					if param.Name == tekton.TektonResolverGitParamRevision {
 						foundRevision = true