-
Notifications
You must be signed in to change notification settings - Fork 54
Open
Description
For certain projects with large number of components and/or ITS resources, integration service can get pretty spammy in gitlab where it has to comment on MRs due to the lack of something comparable to the GitHub Checks API.
Pipelines-as-code has this problem too, but it has a .spec.settings.gitlab.comment_strategy field in its spec that, if set to disable_all, it will stop posting comments in general. That's what the bootc team asked for in the Fedora instance over at https://gitlab.com/fedora/infrastructure/konflux/infra-deployments/-/issues/25#note_2719210012
They realized later that integration-service is another source of spam for them and they'd like to be able to treat it the same way.
Ideas:
- We could teach integration-service to read
.spec.settings.gitlab.comment_strategyoff of theRepositoryresource, but that's probably a bad idea from a coupling PoV - plus there's some tenant-specific/cluster-specific precedence logic they implement that we'd have to re-implement in integration-service. - We could add a
.spec.settings.gitlab.comment_strategyto theIntegrationTestScenarioresource that could be used to control whether or not integration-service will post comments.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels