fix(KONFLUX-141173): remove footnotes on git reporters by NigelByrne1 · Pull Request #1586 · konflux-ci/integration-service

NigelByrne1 · 2026-06-04T10:42:13Z

notes column now displays TEST_OUTPUT.note
footnotes are now duplicating this data
footnotes are misleading in some git reporters
removing them as they are no longer required

assisted by ai: Cursor

Maintainers will complete the following section

Commit messages are descriptive enough (hints)
Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
Controllers diagrams are updated when PR changes controllers code (if applicable)

gemini-code-assist

Code Review

This pull request removes the footnote formatting functionality from the test summary output, simplifying the generated markdown and updating the corresponding tests. The review feedback suggests further refactoring FormatTaskName to remove an obsolete call to GetTestResult(), which will improve performance and simplify the code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

codecov-commenter · 2026-06-04T10:47:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.09%. Comparing base (eb20c77) to head (6bc044b).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
- Coverage   72.86%   72.09%   -0.77%     
==========================================
  Files          63       63              
  Lines        8413     8809     +396     
==========================================
+ Hits         6130     6351     +221     
- Misses       1658     1817     +159     
- Partials      625      641      +16

Flag	Coverage Δ
e2e-tests	`49.17% <100.00%> (+0.04%)`	⬆️
unit-tests	`65.36% <100.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fullsend-ai-review · 2026-06-04T10:51:10Z

Review

Findings

No findings.

The PR cleanly removes the footnote formatting feature from git reporters. The FormatFootnotes function, its template invocation, and the footnote-reference logic in FormatTaskName are all removed together with no stale references remaining. Test expectations are updated consistently — footnote references removed from task names, footnote definitions removed from expected output, and the extra blank lines previously produced by the empty formatFootnotes output are correctly cleaned up. The FormatNote function remains to display notes in the table column, confirming the PR description's claim that footnotes were duplicating data already shown there.

Previous run

Review

Findings

Low

[behavioral-change] status/format.go:211 — FormatTaskName no longer appends [^name] footnote reference suffix when a note exists. The function signature is unchanged but return values differ for tasks with notes. Verified safe: no external consumers of this function exist; it is only used as a template function within FormatTestsSummary. Tests are updated to match.

Info

[output-format-change] status/format.go:282 — Exported function FormatFootnotes is removed. Analysis confirms it was only used internally as a template function. No external repositories depend on the status package.
[scope-tier-alignment] — The PR uses fix() commit type for what is closer to a feature removal/simplification. Removing footnotes that are "misleading in some git reporters" is a reasonable interpretation of a fix, but could also be classified as refactor(). Minor observation, no action needed.

- notes column now displays TEST_OUTPUT.note - footnotes are now duplicating this data - footnotes are misleading in some git reporters - removing them as they are no longer required assisted by ai: Cursor Signed-off-by: nbyrne <nbyrne@redhat.com>

NigelByrne1 · 2026-06-08T14:37:17Z

/retest

NigelByrne1 · 2026-06-08T15:49:57Z

/retest

dirgim

LGTM

jsztuka

lgtm

jsztuka · 2026-06-09T08:54:33Z

/retest

jsztuka · 2026-06-09T12:01:15Z

/retest

NigelByrne1 · 2026-06-09T14:33:22Z

/retest

kasemAlem · 2026-06-10T08:52:49Z

failed to provision cluster
/retest

NigelByrne1 · 2026-06-10T09:14:35Z

/retest

red-hat-konflux · 2026-06-10T09:14:40Z

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

jsztuka · 2026-06-10T09:14:41Z

/retest

red-hat-konflux · 2026-06-10T09:14:47Z

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

NigelByrne1 · 2026-06-10T09:17:52Z

/test

NigelByrne1 · 2026-06-10T09:36:41Z

/test

jsztuka · 2026-06-10T10:11:16Z

/test

kasemAlem · 2026-06-10T10:11:21Z

/retest

NigelByrne1 · 2026-06-16T10:07:03Z

/retest

fullsend-ai-retro · 2026-06-16T12:41:44Z

🤖 Finished Retro · ✅ Success · Started 12:41 PM UTC · Completed 12:49 PM UTC
Commit: ffde3b2 · View workflow run →

fullsend-ai-retro · 2026-06-16T12:49:33Z

Retro: PR #1586 — Remove footnotes on git reporters

Workflow quality: Good. This was a clean human-authored PR (4 additions, 47 deletions, 3 files) that the review agent handled well overall. Two review runs, four human approvals, no rework cycles. Time to merge (12 days) was due to CI cluster provisioning failures requiring multiple /retest cycles — not an agent issue.

One gap identified: The fullsend review agent approved the PR but missed an optimization that gemini-code-assist caught: after removing footnote logic, FormatTaskName always returns name, nil regardless of test result, making the GetTestResult() call (JSON unmarshaling + schema validation) unnecessary dead code. This is a "refactoring completeness" check the review agent could perform.

Skipped proposals (covered by existing issues):

Redundant review dispatch on force-push/synchronize: heavily covered by fullsend-ai/fullsend chore(deps): update google.golang.org/genproto/googleapis/api digest to 8636f87 - autoclosed #1372, fix(KFLUXBUGS-1340): add branch param from fork to snapshot #893, chore(go): bump k8s.io/apimachinery from 0.29.4 to 0.32.0 #963, fix(STONEINTG-1475): fix for gitlab setCommitStatus #1452, and others (10+ open issues).
General review quality gaps vs other bots: partially covered by fix(STONEINTG-1558): fix for retry report failure #1525, #2151, #2062, #2235.

Proposals filed

Review agent should detect newly-unnecessary code paths after simplifying refactors (in fullsend-ai/fullsend)

NigelByrne1 requested review from 14rcole, Josh-Everett, dirgim, jencull, jsztuka, kasemAlem and sonam1412 as code owners June 4, 2026 10:42

github-actions Bot added the size: XS label Jun 4, 2026

gemini-code-assist Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread status/format.go Outdated

fullsend-ai-review Bot approved these changes Jun 4, 2026

View reviewed changes

fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 4, 2026

NigelByrne1 force-pushed the konflux-14173 branch from 2c0ef43 to 6bc044b Compare June 8, 2026 10:28

github-actions Bot added the size: S label Jun 8, 2026

fullsend-ai-review Bot approved these changes Jun 8, 2026

View reviewed changes

fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jun 8, 2026

dirgim approved these changes Jun 8, 2026

View reviewed changes

Josh-Everett approved these changes Jun 8, 2026

View reviewed changes

jsztuka approved these changes Jun 9, 2026

View reviewed changes

kasemAlem approved these changes Jun 9, 2026

View reviewed changes

NigelByrne1 merged commit 1d77a40 into konflux-ci:main Jun 16, 2026
26 checks passed

fullsend-ai-retro Bot mentioned this pull request Jun 16, 2026

Review agent should detect newly-unnecessary code paths after simplifying refactors fullsend-ai/fullsend#2329

Open

rh-tap-build-team Bot mentioned this pull request Jun 16, 2026

integration-service update redhat-appstudio/infra-deployments#12459

Closed

dirgim mentioned this pull request Jun 24, 2026

Promote integration-service from staging to production redhat-appstudio/infra-deployments#12733

Merged

Uh oh!

Conversation

NigelByrne1 commented Jun 4, 2026

Maintainers will complete the following section

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codecov-commenter commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fullsend-ai-review Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Findings

Review

Findings

Low

Info

Uh oh!

NigelByrne1 commented Jun 8, 2026

Uh oh!

NigelByrne1 commented Jun 8, 2026

Uh oh!

dirgim left a comment

Choose a reason for hiding this comment

Uh oh!

jsztuka left a comment

Choose a reason for hiding this comment

Uh oh!

jsztuka commented Jun 9, 2026

Uh oh!

jsztuka commented Jun 9, 2026

Uh oh!

NigelByrne1 commented Jun 9, 2026

Uh oh!

kasemAlem commented Jun 10, 2026

Uh oh!

NigelByrne1 commented Jun 10, 2026

Uh oh!

red-hat-konflux Bot commented Jun 10, 2026

Uh oh!

jsztuka commented Jun 10, 2026

Uh oh!

red-hat-konflux Bot commented Jun 10, 2026

Uh oh!

NigelByrne1 commented Jun 10, 2026

Uh oh!

NigelByrne1 commented Jun 10, 2026

Uh oh!

jsztuka commented Jun 10, 2026

Uh oh!

kasemAlem commented Jun 10, 2026

Uh oh!

NigelByrne1 commented Jun 16, 2026

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Jun 16, 2026

Retro: PR #1586 — Remove footnotes on git reporters

Proposals filed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Jun 4, 2026 •

edited

Loading

fullsend-ai-review Bot commented Jun 4, 2026 •

edited

Loading

fullsend-ai-retro Bot commented Jun 16, 2026 •

edited

Loading