feat(STONEINTG-1546): add plr link to git report#1613
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pipelineRun retrieval logic to format and include a pipeline URL in the fallback message when a pipelineRun is not found, and adds a corresponding unit test. However, the implementation replaces the general error check with a specific 'IsNotFound' check, which silently ignores other API errors and allows the function to proceed with an unpopulated pipelineRun. It is recommended to restore the general error handling to prevent unexpected behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
🤖 Finished Review · ✅ Success · Started 10:00 AM UTC · Completed 10:10 AM UTC |
ReviewFindingsLow
Previous runReviewFindingsLow
Labels: PR adds a UX enhancement (clickable PipelineRun link in error messages). Previous run (2)ReviewFindingsLow
Previous run (3)Looks good to me Previous run (4)ReviewFindingsHigh
Low
|
|
🤖 Finished Review · ✅ Success · Started 11:48 AM UTC · Completed 11:58 AM UTC |
35b967e to
a8c2ee4
Compare
|
🤖 Finished Review · ✅ Success · Started 2:52 PM UTC · Completed 3:03 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
+ Coverage 65.85% 70.38% +4.52%
==========================================
Files 63 71 +8
Lines 8725 11419 +2694
==========================================
+ Hits 5746 8037 +2291
- Misses 2306 2571 +265
- Partials 673 811 +138
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 55 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
a8c2ee4 to
17e4f76
Compare
|
🤖 Finished Review · ✅ Success · Started 8:43 PM UTC · Completed 8:53 PM UTC |
Handle missing pipelinerun gracefully by providing a linkable name. Signed-off-by: aphelan <aphelan@redhat.com>
17e4f76 to
1b8169a
Compare
|
🤖 Finished Review · ✅ Success · Started 8:28 AM UTC · Completed 8:36 AM UTC |
|
/ok-to-test |
|
/retest |
|
well done, thanks @ainephelan365 |
-created clickable url link in status.go
Maintainers will complete the following section