Skip to content

Commit 8e38a55

Browse files
authored
Merge pull request #49 from konflux-ci/fix-test-warnings
fix: Properly mock OIDC responses
2 parents f297aa8 + 6874935 commit 8e38a55

1 file changed

Lines changed: 30 additions & 12 deletions

File tree

tests/cmd/upload/test_oidc.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -232,24 +232,42 @@ async def test__request_fail_on_error(
232232

233233

234234
@pytest.mark.asyncio
235-
@patch("mobster.cmd.upload.oidc.OIDCClientCredentialsClient._request")
236-
async def test_put(mock_request: AsyncMock) -> None:
235+
async def test_put() -> None:
237236
client = _get_valid_client()
238237

239-
await client.put("foo", '{"file": ""}', headers={"header": "test"})
238+
with patch.object(
239+
client,
240+
"_request",
241+
new_callable=AsyncMock,
242+
return_value=MagicMock(),
243+
) as mock_request:
244+
await client.put("foo", '{"file": ""}', headers={"header": "test"})
240245

241-
mock_request.assert_awaited_once_with(
242-
"put", "foo", content='{"file": ""}', headers={"header": "test"}, params=None
243-
)
246+
mock_request.assert_awaited_once_with(
247+
"put",
248+
"foo",
249+
content='{"file": ""}',
250+
headers={"header": "test"},
251+
params=None,
252+
)
244253

245254

246255
@pytest.mark.asyncio
247-
@patch("mobster.cmd.upload.oidc.OIDCClientCredentialsClient._request")
248-
async def test_post(mock_request: AsyncMock) -> None:
256+
async def test_post() -> None:
249257
client = _get_valid_client()
250258

251-
await client.post("foo", '{"file": ""}', headers={"header": "test"})
259+
with patch.object(
260+
client,
261+
"_request",
262+
new_callable=AsyncMock,
263+
return_value=MagicMock(),
264+
) as mock_request:
265+
await client.post("foo", '{"file": ""}', headers={"header": "test"})
252266

253-
mock_request.assert_awaited_once_with(
254-
"post", "foo", content='{"file": ""}', headers={"header": "test"}, params=None
255-
)
267+
mock_request.assert_awaited_once_with(
268+
"post",
269+
"foo",
270+
content='{"file": ""}',
271+
headers={"header": "test"},
272+
params=None,
273+
)

0 commit comments

Comments
 (0)