From bfefc739028c1d24e0f0c9e90dd1cd756d7cf9e7 Mon Sep 17 00:00:00 2001 From: fullsend-code <278716306+fullsend-ai-coder[bot]@users.noreply.github.com> Date: Fri, 26 Jun 2026 18:27:48 +0000 Subject: [PATCH] docs(#206): update stale Go 1.21 references to 1.22 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit go.mod was bumped from 1.21 to 1.22.0 but documentation files were not updated. Fixed all five stale references across CLAUDE.md, AGENTS.md, skills/ci-cd-quirks/SKILL.md, and skills/debugging-cli-locally/SKILL.md to match the current go.mod directive. Also updated the debugging skill's advice since local vs CI Go version mismatch is no longer the primary concern — the Dockerfile UBI9 go-toolset version is. Closes #206 --- AGENTS.md | 2 +- CLAUDE.md | 2 +- skills/ci-cd-quirks/SKILL.md | 4 ++-- skills/debugging-cli-locally/SKILL.md | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 64609ff9..c6367501 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -56,4 +56,4 @@ make pre-commit # All hooks - Viper binds lowercase flag names but reads UPPERCASE env vars (e.g., `slack_token` -> `SLACK_TOKEN`) - Config files read relative to CWD (container WORKDIR `/qe-tools`); OCI download hardcodes `quay.io/` — other registries rejected -- Go version mismatch: `go.mod`=1.21, CI=1.22, Dockerfile UBI9 go-toolset varies by tag +- Go version mismatch: `go.mod`=1.22, CI=1.22, Dockerfile UBI9 go-toolset varies by tag diff --git a/CLAUDE.md b/CLAUDE.md index 4eaf0428..9bfad3ba 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -146,4 +146,4 @@ Scans GCS bucket structure for Prow job artifacts. Maps step names to artifact f - **Regex match safety**: Functions parsing text with regex should always validate the match result length before accessing capture group indices -- `FindStringSubmatch` returns nil on no match - **Fallthrough in match functions**: Functions that iterate over a set of conditions and return on the first match should handle the case where nothing matches - **pre-commit hooks run full test suite**: `go-test-mod` in `.pre-commit-config.yaml` runs all tests on every commit, which can be slow -- **Go version mismatch**: `go.mod` says 1.21, CI uses 1.22, Dockerfile uses UBI9 go-toolset (Go version varies by tag) +- **Go version mismatch**: `go.mod` says 1.22, CI uses 1.22, Dockerfile uses UBI9 go-toolset (Go version varies by tag) diff --git a/skills/ci-cd-quirks/SKILL.md b/skills/ci-cd-quirks/SKILL.md index 582ab3b1..6b326798 100644 --- a/skills/ci-cd-quirks/SKILL.md +++ b/skills/ci-cd-quirks/SKILL.md @@ -15,11 +15,11 @@ Three different Go versions are in play: | Location | Go Version | Source | |----------|-----------|--------| -| `go.mod` | 1.21 | Module minimum compatibility | +| `go.mod` | 1.22 | Module minimum compatibility | | CI (`test.yml`, `lint.yml`) | 1.22 | `actions/setup-go` in workflows | | Dockerfile | Varies | UBI9 `go-toolset` (version depends on tag) | -**Consequence**: Code may compile locally with Go 1.22 features but fail in the container if the UBI9 image ships an older Go. Stick to Go 1.21 language features unless `go.mod` is bumped. +**Consequence**: Code may compile locally with Go 1.22 features but fail in the container if the UBI9 image ships an older Go. Stick to Go 1.22 language features unless `go.mod` is bumped. ## Quirk 2: Pre-commit Runs Full Test Suite diff --git a/skills/debugging-cli-locally/SKILL.md b/skills/debugging-cli-locally/SKILL.md index 2a0fd1d2..2b6aeb25 100644 --- a/skills/debugging-cli-locally/SKILL.md +++ b/skills/debugging-cli-locally/SKILL.md @@ -104,5 +104,5 @@ make pre-commit | `panic: index out of range` | Regex `FindStringSubmatch` returned nil, code accessed `[1]` | Check `len(matches)` before indexing | | `GITHUB_TOKEN must be set` | Env var not exported | `export GITHUB_TOKEN="$YOUR_TOKEN"` | | `golangci-lint` ignores config | Config is `.golang-ci.yml` not `.golangci.yml` | Use `make lint` or `-c .golang-ci.yml` | -| Tests pass locally, fail in CI | Go version mismatch (local 1.22, go.mod 1.21) | Avoid 1.22-only features | +| Tests pass locally, fail in CI | Go version mismatch (local 1.22, go.mod 1.22) | Check Dockerfile UBI9 go-toolset version | | `permission denied` on binary | Built binary not executable | `chmod +x qe-tools` or use `go run` |