Skip to content

feat(HUM-2061): optimize filter-already-released-advisory-rpms for speed and reliability#2233

Merged
johnbieren merged 1 commit into
konflux-ci:developmentfrom
scoheb:HUM-2061-filter-already-released-advisory-rpms
Jun 8, 2026
Merged

feat(HUM-2061): optimize filter-already-released-advisory-rpms for speed and reliability#2233
johnbieren merged 1 commit into
konflux-ci:developmentfrom
scoheb:HUM-2061-filter-already-released-advisory-rpms

Conversation

@scoheb

@scoheb scoheb commented May 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Refactor managed and internal filter tasks for large advisory handling
  • Add oras authentication and credential setup for OCI artifact access
  • Fix argument-too-long errors with large RPM lists using file-based processing
  • Optimize purl-to-advisory mapping build performance
  • Treat unpublished advisory RPMs as unreleased (correct filtering logic)
  • Restore advisory as authoritative source of truth for release state
  • Add internal pipeline for filter task orchestration
  • Add unit tests for all-released, no-advisories, and partial-release scenarios
  • Update CI config and local test runner for filter task test support

Test plan

  • Unit tests pass for tasks/managed/filter-already-released-advisory-rpms
  • Unit tests pass for tasks/internal/filter-already-released-advisory-rpms-task
  • Integration test passes (when full stack is assembled in later PRs)

Jira

https://redhat.atlassian.net/browse/HUM-2061

Part of HUM-959 - PR 1 of 6

🤖 Generated with Claude Code

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 3346fcc to 98f0c76 Compare May 20, 2026 18:01
Comment thread .github/workflows/tekton_task_tests.yaml Outdated
Comment thread scripts/run-local-tests.sh Outdated
Comment thread tasks/internal/filter-already-released-advisory-rpms-task/tests/mocks.sh Outdated
@scoheb scoheb requested a review from mmalina May 21, 2026 13:47
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch 3 times, most recently from 561382f to 662e337 Compare May 21, 2026 16:54
mmalina
mmalina previously approved these changes May 25, 2026
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 662e337 to 7989c6d Compare May 25, 2026 16:29
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 63ff635 to c27f30e Compare May 25, 2026 21:02
@scoheb scoheb requested a review from mmalina May 26, 2026 14:23
@mmalina

mmalina commented May 26, 2026

Copy link
Copy Markdown
Contributor

gitlint is failing on too long of a line. but also, I think you can squash the commits now.

@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch 2 times, most recently from a7d37b4 to 66228f5 Compare May 26, 2026 14:51
mmalina
mmalina previously approved these changes May 28, 2026
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 66228f5 to 869cce1 Compare May 28, 2026 12:50
davidmogar
davidmogar previously approved these changes May 29, 2026
johnbieren
johnbieren previously approved these changes May 29, 2026
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 869cce1 to f976089 Compare May 29, 2026 16:02
@scoheb

scoheb commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/retest

@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch 4 times, most recently from 9965877 to 785bb85 Compare June 4, 2026 15:20
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Inline suggestions were posted as code suggestions.

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Inline suggestions were posted as code suggestions.

Comment thread pipelines/internal/filter-already-released-advisory-rpms/README.md
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Inline suggestions were posted as code suggestions.

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Inline suggestions were posted as code suggestions.

Refactor managed and internal filter tasks for large advisory handling
with oras auth and credential setup. Fix arg-too-long errors using
file-based processing. Optimize purl-to-advisory mapping performance.
Treat unpublished advisory RPMs as unreleased. Restore advisory as
authoritative source of truth. Add direct task results for test
validation. Add internal pipeline and unit tests. Update local test
runner.

Unquote ORAS_OPTIONS to prevent empty arg: when ORAS_OPTIONS is empty,
"${ORAS_OPTIONS:-}" produces an empty string argument that oras
interprets as the reference, causing "invalid reference: missing
registry or repository". Add shellcheck disable directives for the
intentionally unquoted variable.

Signed-off-by: Scott Hebert <shebert@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Scott Hebert <scoheb@gmail.com>
@scoheb scoheb force-pushed the HUM-2061-filter-already-released-advisory-rpms branch from 785bb85 to 29617f0 Compare June 4, 2026 17:29
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Inline suggestions were posted as code suggestions.

@scoheb scoheb requested a review from mmalina June 4, 2026 17:43
@ach912

ach912 commented Jun 8, 2026

Copy link
Copy Markdown

Production Approval Record

Field Value
Action APPROVED
Reviewer @ach912
Timestamp 2026-06-08T10:11:50.437Z

Approved

@johnbieren johnbieren added this pull request to the merge queue Jun 8, 2026
Merged via the queue into konflux-ci:development with commit aa8c383 Jun 8, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants