feat(RELEASE-1993): convert update-fbc-catalog-task to python#2268
Merged
FilipNikolovski merged 2 commits intoJun 19, 2026
Conversation
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
3 times, most recently
from
7580fae to
f48a550
Compare
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
2 times, most recently
from
ba84072 to
68ae69c
Compare
Contributor
Author
|
/retest |
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
2 times, most recently
from
73aad13 to
8fa65a4
Compare
Contributor
Author
|
/retest |
FilipNikolovski
requested review from
arewm,
gbenhaim,
ralphbean and
twaugh
as code owners
mmalina
reviewed
Jun 11, 2026
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
from
8fa65a4 to
2542c93
Compare
mmalina
reviewed
Jun 11, 2026
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
from
95c3171 to
2af3013
Compare
mmalina
approved these changes
Jun 15, 2026
davidmogar
approved these changes
Jun 15, 2026
johnbieren
reviewed
Jun 15, 2026
johnbieren
approved these changes
Jun 15, 2026
johnbieren
left a comment
johnbieren
left a comment
Collaborator
There was a problem hiding this comment.
lgtm but yeah idk if it will merge cleanly
Replace the two inline bash steps with a call to the standalone Python script in the release-service-utils image. Tekton test mocks are converted to the declarative mocks.yaml pattern compatible with the Python entrypoint, and scenario-specific tests now covered by pytest in the utils repo are removed. Fix TASK_ENTRYPOINT quoting in test_tekton_tasks.sh: args with Tekton placeholders were wrapped in double quotes, which breaks when the substituted value has embedded double quotes (e.g. JSON arrays). Switched to single quotes so the value is preserved literally after Tekton substitution. Assisted-by: Claude Code Signed-off-by: Filip Nikolovski <fnikolov@redhat.com>
Add tests/python_mocks/ support to the test mock framework, mirroring the existing tests/mocks/ pattern for CLI binaries. Files placed in python_mocks/ are written to a temp directory prepended to PYTHONPATH so task scripts import the mock instead of the real package. Replace the mocks/python3 interpreter wrapper in update-fbc-catalog-task with a clean python_mocks/requests_kerberos.py stub. Assisted-by: Claude Code Signed-off-by: Filip Nikolovski <fnikolov@redhat.com>
FilipNikolovski
force-pushed
the
RELEASE-1993
branch
from
2af3013 to
40c8c1f
Compare
twaugh
approved these changes
Jun 16, 2026
Collaborator
Production Approval Record
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replace the two inline bash steps with a call to the python script in the release-service-utils image. Tekton test mocks are converted to the declarative mocks.yaml pattern compatible with the Python entrypoint, and scenario-specific tests that are now covered by pytest in the utils repo are removed.
Assisted-by: Claude Code
Relevant Jira
https://redhat.atlassian.net/browse/RELEASE-1993
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.shAssisted-By: Cursor