refactor(RELEASE-2480): convert collect-registry-token-secret to python#2340
Draft
happybhati wants to merge 1 commit into
Draft
Conversation
Replaces inline bash in collect-secret step with the standalone python script from release-service-utils. One happy-path Tekton test; fail scenarios covered by pytest in utils. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This commit replaces the inline bash script for the collect-registry-token-secret
managed task with a standalone python script contained in the utils image.
The tekton unit tests are updated accordingly. We only keep one happy path
test as the other scenarios are covered by pytest in the utils repo.
Depends on (merge first): konflux-ci/release-service-utils#860
TODO before merge: Update the
image:digest incollect-registry-token-secret.yamlonce the Konflux
on-prbuild for utils #860 is available, then/retestthis PR.After utils merges, bump to
quay.io/konflux-ci/release-service-utils@sha256:<main-digest>Assisted-by: Cursor
Relevant Jira
RELEASE-2480
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.shAssisted-By: Cursor