Skip to content

chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3#1000

Draft
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x
Draft

chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3#1000
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
gomodules.xyz/jsonpatch/v2 v2.5.0 → v3.0.1 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.

Release Notes

gomodules/jsonpatch (gomodules.xyz/jsonpatch/v2)

v3.0.1

Compare Source

This release uses our forked gomodules/orderedmap library. Our forked version has 2 major changes:

  • Uses *OrderedMap instead of OrderedMap inside nested orderedmaps.
  • I ported unstructured helpers from Kubernetes to work with orderedmaps.

v3.0.0

Compare Source

This release uses iancoleman/orderedmap to generate predictable patch. This is very useful if the generated patch is checked into a VCS like git.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@johnbieren johnbieren marked this pull request as draft October 25, 2025 12:58
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Oct 26, 2025
@red-hat-konflux red-hat-konflux Bot closed this Oct 26, 2025
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch October 26, 2025 12:29
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Oct 26, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Oct 26, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch 2 times, most recently from 13461a1 to 0908575 Compare October 30, 2025 12:33
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch from 0908575 to e70bde2 Compare November 4, 2025 04:46
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch 3 times, most recently from 4647783 to 0d9fc70 Compare November 14, 2025 13:37
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Nov 22, 2025
@red-hat-konflux red-hat-konflux Bot closed this Nov 22, 2025
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Nov 22, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Nov 22, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch 2 times, most recently from 0d9fc70 to 02d42a3 Compare November 25, 2025 09:32
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch from 02d42a3 to 0e1cc3f Compare December 3, 2025 17:30
@snyk-io

snyk-io Bot commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/gomodules.xyz-jsonpatch-v2-3.x branch 8 times, most recently from c34ade8 to f0fb72d Compare December 9, 2025 05:38
fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:49 PM UTC · Completed 2:55 PM UTC
Commit: 7acff03 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:12 PM UTC · Completed 8:18 PM UTC
Commit: 0d0162a · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:21 PM UTC · Completed 1:28 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:03 PM UTC · Completed 9:09 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:35 PM UTC · Completed 8:43 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:03 PM UTC · Completed 2:10 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:51 PM UTC · Completed 6:00 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:30 AM UTC · Completed 11:39 AM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:39 PM UTC · Completed 3:46 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:50 AM UTC · Completed 10:57 AM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 4:42 PM UTC · Completed 4:49 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:32 PM UTC · Completed 2:39 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 1:39 AM UTC · Completed 1:44 AM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 2, 2026

Copy link
Copy Markdown

Retro: PR #1000 — Bot dependency update reviewed 21 times

PR #1000 is a Renovate/MintMaker bot PR that attempted an invalid Go module major version swap (jsonpatch/v2 → v3). The change was fundamentally broken — CI failed on every single push — and the PR was converted to draft by a human reviewer on day one. Despite this, the review agent ran 21 review cycles over ~2.5 weeks, each time producing the same correct findings (invalid module path change, missing go.sum update). The PR was never merged and is now closed after being open for 8+ months with dozens of automated rebases.

Token waste estimate

At minimum 20 of the 21 review runs were unnecessary — the findings never changed because the diff never changed (only rebases). This represents significant wasted compute.

Root causes (all have existing open issues)

This PR is a textbook case for several known improvement areas, all already tracked:

  1. Draft PR reviews not skipped → #1715 — The PR was marked draft on day 1, but reviews kept running.
  2. Bot-authored PRs not skipped → #1371 — The PR author is red-hat-konflux[bot]. A simple author check would skip or reduce reviews.
  3. Rebase-only re-reviews not skipped → #1287, #1355 — Dozens of force-pushes were all rebase-only with no semantic diff change.
  4. No hard cap on review dispatches → #2587, #2599 — Even if other gates failed, a cap at e.g. 5 reviews would have stopped the bleeding.
  5. No circuit breaker → #902 — The review-dispatch loop had no backstop.
  6. Finding deduplication missing → #1013, #2816 — Each review posted the same inline comments.
  7. CI failure not considered → #2667 — CI failed on every push; the review agent could have noted this and avoided a full re-review.
  8. Recommend closing unfixable bot PRs → #2586 — The review agent correctly identified the PR as unfixable but never recommended closing it.

Conclusion

Any single one of issues #1715, #1371, or #2587 would have prevented most of the waste. Implementing them in combination would eliminate this class of problem entirely. No new proposals needed — the existing issue backlog comprehensively covers every improvement opportunity surfaced by this PR. This retro serves as additional evidence for prioritizing these issues, particularly #1715 (draft skip) and #1371 (bot skip) as the highest-leverage fixes.

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:09 AM UTC · Completed 6:16 AM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Sign in to view

@red-hat-konflux
chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3
c165c70 
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:44 PM UTC · Completed 2:51 PM UTC
Commit: ec21706 · View workflow run →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fullsend-ai-review fullsend-ai-review[bot] fullsend-ai-review[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@johnbieren johnbieren

@jinqi7 jinqi7

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code requires-manual-review Review requires human judgment Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnbieren @jinqi7