Create tests for block creation

[PiotrZierhoffer]

Check if splitting works correctly etc

[konrad-kruczynski]

The problem we've discussed should be fixed now. Will you create some tests (also to check it)?

[PiotrZierhoffer]

The question is: what do we want to check?

I'd go with everything. That is: simple statements, statements with a call, if's, loops, calls etc. Along with new features we'll add new tests. What do you think?

[PiotrZierhoffer]

Another question:

let's say I have a code:

int i = 5;
if(i > 0)
  i -= 2;
return;

This might be analyzed in order: 1->2->4->3 (current algorithm, 3 blocks) or 1->2->3->4 (2 blocks), depending on the algorithm in analyzer and on the actual IL behind. IL will be static for the test, but should we allow changes in the algorithm? What I mean: should we check if we detect 3 blocks or 2-3 blocks?

I'm for option no. 1.

[PiotrZierhoffer]

Should we check only for the blocks count or their boundaries as well?

[konrad-kruczynski]

Writing tests in a way that they will be 100% black box is not that easy. As you've written - the result depends at least on whether we first analyse condition fulfilled branch or the other one. Therefore I would write test for the current version and adapt them if necessary.

For the second question - we should check number and boundaries.

[PiotrZierhoffer]

Add VerifyAnalysisResults(params int[] boundaries, blocks) - this will reduce the amount of writing.
Inside sort blocks by their beginning, verify count and boundaries from argument (as pairs of numbers, enter-separated ;-)).