Multiple Exports

[nkooman-bzs]

Brief bug description

When using v8.0.0-8 of the model generator, it is possible to create conflicting type names.

Repro steps

1. Create a content type and content type snippet with the same name
2. Generate delivery models
3. See that those names will conflict in the barrel file exporting all delivery types.

Expected behavior

Export all snippets/types/taxonomies/etc under a unique name.
e.g. ContentTypes.Banner and ContentTypeSnippets.Banner

Test environment

• Version 8.0.0-8

Screenshots

Error in barrel file:

Conflicting types:

[Enngage]

Hi @nkooman-bzs,

sorry the late reply. I've missed this issue completely :)

You're right that this conflict may happen, though I'm not sure if we want to enforce any prefix/suffix to prevent that from happening. You can quite easily modify the names of the objects in Delivery models in the way you mentioned by using the nameResolvers option:

await generateDeliveryModelsAsync({
        addTimestamp: false,
        environmentId: x,
        apiKey: y,
        moduleFileExtension: 'js',
        nameResolvers: {
            contentType: (item) => `ContentType_${resolveCase(item.name, 'pascalCase')}`,
            snippet: (item) => `ContentTypeSnippet_${resolveCase(item.name, 'pascalCase')}`,
            taxonomy: (item) => `Taxonomy_${resolveCase(item.name, 'pascalCase')}`
        }
    });

I think this should be enough for most people :) We could expose prefix/suffix in a config for the CLI usage, but that seems rather unnecessary.

Are you able to solve your issue with the above? ;)

[nkooman-bzs]

This would fix the issue yes. However, I'm looking to not prefix the actual type but rather namespace the types themselves.
I think a potential solution would be to have a toggle to choose whether the barrel files generate export * from '...' vs export * as ContentTypes from '...'

[Enngage]

That makes sense although it would mean you can import the same type either with/without namespace.

I'm keeping it open as we might add an option for using namespaces in future, but we don't plan it for the next major release.