Skip to content

[RFE] Allow users to dismiss issues #185

Open
@rromannissen

Description

@rromannissen

What is the problem?

Analysis might produce issues that are not meaningful for the user. These issues might come from false positives (which should be reported and considered a problem to solve by the Konveyor team) or from the rules being too orthodox, especially the ones that come out of the box with the tool. It should be possible for the knowledgeable user to dismiss issues that are not applicable in the context of a certain organization or are explicitly not going to be addressed.

A valid example for the need of this could be for an organization that wishes to migrate to EAP 7. Part of those rules include the upgrade of Hibernate to the version that comes packaged with the application server, considering that deployed applications make full use of the available libraries in the Application Server, but the organization packages the Hibernate library with the application itself as a direct dependency. This means that the rules related to the Hibernate upgrade wouldn't apply, as it is not required in this case. While it is true that the user could skip those Hibernate rules by adding their labels to the ignore list for the analysis, that would require a way deeper knowledge of the inner workings of Konveyor and the rules that come bundled with it, which would only be applicable for very advanced users.

Why is this a problem?

Too much noise in the analysis results might render them unusable. It should be up to the experienced user to determine which issues should be addressed in the context of a modernization initiative. If certain issues do not apply in the context of an organization or are not going to be addressed for valid reasons as explained in the previous section, it doesn't make sense to still display story points for applications that are affected by them.

Allowing architects to dismiss certain issues would also allow them to maintain the focal point in what is important for the organization and prioritize work for the migrators.

Proposed solution

  • Architects and Administrators should be allowed to dismiss issues at application or portfolio level:
    • Portfolio level dismissal will be done from the All Issues tab from the Issues view.
    • Application level dismissal will be done from the Affected applications view from the All Issues tab from the Issues view and the Single application tab from the Issues view.
  • Architects should be able to view dismissed issues using a dedicated filter for that in the Issues view.
  • Architects should be able to reconstitute dismissed issues.
  • The ability to dismiss issues should be configured by the Administrator at instance level, probably as an option under the General view from the Administration perspective.
  • Story points coming from dismissed issues shouldn't be counted on the total story points for applications affected by that issue.

Open Questions

  • How does this translate in terms of UI/UX in the CLI and IDE plugins? Could there be a way to define this as a corporate policy that the CLI and the IDE plugins can consume? How does this affect the Backstage integration?

Metadata

Metadata

Labels

kind/featureCategorizes issue or PR as related to a new feature.priority/majorImportant over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

Status

🔖 Ready

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions