🐛 Fixes #472 Remove stateless kai resources when set to false (#533) (#539)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Ensured config always includes a proper models mapping and added a
terminating newline to avoid parsing issues.

* **Refactor**
* Simplified deployment logic to use centralized state flags, reducing
nested conditions and improving reliability of component provisioning.

* **Chores**
* Rendered database-related environment settings only when the
corresponding service is enabled to prevent unnecessary configuration
exposure.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>

Signed-off-by: Jason Montleon <jmontleo@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Jason Montleon <jmontleo@redhat.com>

Author: konveyor-ci-bot[bot]

roles/tackle/tasks/kai.yml

@@ -1,4 +1,9 @@
 ---
+- name: Set Kai deployment state
+  set_fact:
+    kai_common_state: "{{ 'present' if (kai_solution_server_enabled | bool or kai_llm_proxy_enabled | bool) else 'absent' }}"
+    kai_llm_proxy_state: "{{ 'present' if kai_llm_proxy_enabled | bool else 'absent' }}"
+    kai_solution_server_state: "{{ 'present' if kai_solution_server_enabled | bool else 'absent' }}"
 
 - name: Get API key secret
   k8s_info:
@@ -10,7 +15,6 @@
 
 - when: kai_llm_proxy_enabled|bool or kai_solution_server_enabled|bool
   block:
-
     - name: Check if DB secret is defined
       k8s_info:
         api_version: v1
@@ -45,58 +49,53 @@
         pg_password: "{{ kai_db_secret_status.resources.0.data.POSTGRESQL_PASSWORD | b64decode }}"
       when: (kai_db_secret_status.resources|length) > 0
 
-    - name: Deploy KAI DB
-      k8s:
-        state: present
-        template: kai/kai-db-deployment.yaml.j2
-
-    - name: Create KAI DB Service
-      k8s:
-        state: present
-        template: kai/kai-db-service.yaml.j2
-
     - name: Create KAI DB PersistentVolumeClaim
       k8s:
         state: present
         template: kai/kai-db-pvc.yaml.j2
 
-
-    - name: Deploy LLM Proxy
-      when: kai_llm_proxy_enabled | bool
-      block:
-        - name: Create LLM Proxy ConfigMap
-          k8s:
-            state: present
-            template: kai/llm-proxy-configmap.yaml.j2
-
-        - name: Create LLM Proxy Deployment
-          k8s:
-            state: present
-            template: kai/llm-proxy-deployment.yaml.j2
-
-        - name: Create LLM Proxy Service
-          k8s:
-            state: present
-            template: kai/llm-proxy-service.yaml.j2
-
-        - name: Create LLM Proxy Client Configuration
-          k8s:
-            state: present
-            template: kai/llm-proxy-client-configmap.yaml.j2
-
-    - name: Deploy Solution server
-      when: kai_solution_server_enabled | bool
-      block:
-        - name: Create Kai API deployment
-          k8s:
-            state: present
-            template: kai/kai-api-deployment.yaml.j2
-            merge_type: merge
-
-        - name: Create KAI API Service
-          k8s:
-            state: present
-            template: kai/kai-api-service.yaml.j2
+- name: Deploy KAI DB
+  k8s:
+    state: "{{ kai_common_state }}"
+    template: kai/kai-db-deployment.yaml.j2
+
+- name: Create KAI DB Service
+  k8s:
+    state: "{{ kai_common_state }}"
+    template: kai/kai-db-service.yaml.j2
+
+- name: Create LLM Proxy ConfigMap
+  k8s:
+    state: present
+    template: kai/llm-proxy-configmap.yaml.j2
+  when: kai_llm_proxy_enabled | bool
+
+- name: Create LLM Proxy Deployment
+  k8s:
+    state: "{{ kai_llm_proxy_state }}"
+    template: kai/llm-proxy-deployment.yaml.j2
+
+- name: Create LLM Proxy Service
+  k8s:
+    state: "{{ kai_llm_proxy_state }}"
+    template: kai/llm-proxy-service.yaml.j2
+
+- name: Create LLM Proxy Client Configuration
+  k8s:
+    state: present
+    template: kai/llm-proxy-client-configmap.yaml.j2
+  when: kai_llm_proxy_enabled | bool
+
+- name: Create Kai API deployment
+  k8s:
+    state: "{{ kai_solution_server_state }}"
+    template: kai/kai-api-deployment.yaml.j2
+    merge_type: merge
+
+- name: Create KAI API Service
+  k8s:
+    state: "{{ kai_solution_server_state }}"
+    template: kai/kai-api-service.yaml.j2
 
 - name: Update Kai component status conditions
   when: ansible_operator_meta is defined

roles/tackle/templates/kai/kai-api-deployment.yaml.j2

@@ -24,8 +24,10 @@ spec:
               value: /api
             - name: KAI_LLM_PARAMS
               value: '{{ kai_llm_params | to_json }}'
+{% if kai_solution_server_enabled|bool %}
             - name: KAI_DB_DSN
               value: 'postgresql+asyncpg://kai:{{ pg_password }}@{{ kai_database_address }}:5432/kai'
+{% endif %}
 {% if kai_api_key_secret_status.resources | length > 0 %}
 {% for (key, value) in kai_api_key_secret_status.resources.0.data.items() %}
             - name: {{ key }}

roles/tackle/templates/kai/llm-proxy-configmap.yaml.j2

@@ -87,14 +87,14 @@ data:
           table_name: llm_proxy_conversations
           backend: sql_default
     registered_resources:
-      models:
 {% if kai_llm_model %}
+      models:
       - model_id: proxied-model
         provider_id: {{ kai_llm_proxy_provider_id }}
         model_type: llm
         provider_model_id: {{ kai_llm_model }}
 {% else %}
-      []
+      models: []
 {% endif %}
       shields: []
       vector_dbs: []
@@ -118,4 +118,4 @@ data:
           audience: "{{ keycloak_api_audience }}"
 {% endif %}
     telemetry:
-      enabled: false
+      enabled: false