Add testing, fix clippy lints

Author: korken89

.github/workflows/ci.yml

@@ -0,0 +1,109 @@
+name: CI
+
+on:
+  push:
+    branches: [ master, main ]
+  pull_request:
+    branches: [ master, main ]
+
+env:
+  CARGO_TERM_COLOR: always
+  RUSTFLAGS: -D warnings
+
+jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@stable
+
+    - name: Cache cargo registry
+      uses: actions/cache@v4
+      with:
+        path: ~/.cargo/registry
+        key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
+
+    - name: Cache cargo index
+      uses: actions/cache@v4
+      with:
+        path: ~/.cargo/git
+        key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}
+
+    - name: Cache cargo build
+      uses: actions/cache@v4
+      with:
+        path: target
+        key: ${{ runner.os }}-cargo-build-target-${{ hashFiles('**/Cargo.lock') }}
+
+    - name: Run tests (default features)
+      run: cargo test
+
+    - name: Run tests (all features)
+      run: cargo test --all-features
+
+    - name: Run tests (no default features)
+      run: cargo test --no-default-features
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@stable
+      with:
+        components: clippy
+
+    - name: Run clippy
+      run: cargo clippy --all-targets --all-features -- -D warnings
+
+  fmt:
+    name: Formatting
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@stable
+      with:
+        components: rustfmt
+
+    - name: Check formatting
+      run: cargo fmt --all -- --check
+
+  doc:
+    name: Documentation
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@stable
+
+    - name: Build documentation
+      run: cargo doc --all-features --no-deps
+      env:
+        RUSTDOCFLAGS: -D warnings
+
+  miri:
+    name: Miri
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@nightly
+      with:
+        components: miri
+
+    - name: Run Miri
+      run: cargo miri test

.github/workflows/security-audit.yml

@@ -0,0 +1,31 @@
+name: Security Audit
+
+on:
+  schedule:
+    # Run weekly on Sunday at 00:00 UTC
+    - cron: '0 0 * * 0'
+  push:
+    paths:
+      - '**/Cargo.toml'
+      - '**/Cargo.lock'
+  pull_request:
+    paths:
+      - '**/Cargo.toml'
+      - '**/Cargo.lock'
+
+jobs:
+  security-audit:
+    name: Cargo Audit
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install Rust toolchain
+      uses: dtolnay/rust-toolchain@stable
+
+    - name: Install cargo-audit
+      run: cargo install cargo-audit
+
+    - name: Run cargo audit
+      run: cargo audit

README.md

@@ -93,8 +93,8 @@ let result = hasher.finalize();
 
 Licensed under either of:
 
-- Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
-- MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)
+- Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or <http://www.apache.org/licenses/LICENSE-2.0>)
+- MIT license ([LICENSE-MIT](LICENSE-MIT) or <http://opensource.org/licenses/MIT>)
 
 at your option.
 

src/hash_impl.rs

@@ -144,8 +144,8 @@ impl Hasher {
             // Full buffer, absorb it.
             if self.buffer_len == RATE {
                 let state_bytes = self.state.as_bytes_mut();
-                for i in 0..RATE {
-                    state_bytes[i] ^= self.buffer[i];
+                for (i, byte) in self.buffer.iter().enumerate().take(RATE) {
+                    state_bytes[i] ^= byte;
                 }
                 gimli(&mut self.state);
 
@@ -158,8 +158,8 @@ impl Hasher {
     pub fn finalize(mut self) -> [u8; HASH_SIZE] {
         // Process buffered data with padding.
         let state_bytes = self.state.as_bytes_mut();
-        for i in 0..self.buffer_len {
-            state_bytes[i] ^= self.buffer[i];
+        for (i, byte) in self.buffer.iter().enumerate().take(self.buffer_len) {
+            state_bytes[i] ^= byte;
         }
 
         // Padding: domain separation at current position, padding marker at end of rate.

src/rustcrypto_aead.rs

@@ -134,7 +134,7 @@ mod tests {
         let plaintext = *b"Hello, RustCrypto AEAD!";
         let aad = b"associated data";
 
-        let mut ciphertext = plaintext.clone();
+        let mut ciphertext = plaintext;
         let tag = cipher
             .encrypt_in_place_detached(&nonce, aad, &mut ciphertext)
             .expect("encryption failed");