refactor: improve type safety and ui consistency across extensions (#13)

* refactor: improve type safety and ui consistency across extensions

* refactor: improve code clarity and move type checking to lint script

* docs: update changelog

Author: kostyay

CHANGELOG.md

@@ -22,7 +22,13 @@ All notable changes to agent-stuff are documented here.
 
 
 
-## feat/force-push-on-rejection
+
+
+## refactor/type-safety-and-ui-updates
+
+Improved type safety across the extension system by adding explicit TypeScript type annotations and migrating from string-based to typed enum patterns for UI colors and notification levels (#13). Reorganized the linting pipeline to include TypeScript type checking via `tsc --noEmit`, catching previously undetected type errors in message content handling, component rendering, and event data access. Standardized UI component property names for consistency (e.g., `selectedBg` → `selectedPrefix`, `matchHighlight` → `selectedText`) and updated notification severity levels to use semantic theme colors (`success`/`info` → `info`/`accent`). Removed ~2,100 lines of unused code and added comprehensive test coverage for the plan-ask extension, improving maintainability and reducing technical debt.
+
+## [1.0.1](https://github.com/kostyay/agent-stuff/pull/12) - 2026-03-02
 
 Enhanced the push workflow to gracefully handle rejected pushes by prompting users to force-push with `--force-with-lease` (#12). When a normal push fails due to non-fast-forward errors (common after rebasing), users are now prompted to safely force-push rather than failing silently. The implementation includes rejection detection via stderr pattern matching and proper error handling for both standard and force-push attempts, with user-facing notifications at each step.
 

package.json

@@ -9,7 +9,7 @@
   "readme": "README.md",
   "type": "module",
   "scripts": {
-    "lint": "eslint --fix pi-extensions/ tests/",
+    "lint": "eslint --fix pi-extensions/ tests/ && npx tsc --noEmit",
     "test": "npm run lint && node --experimental-strip-types --test tests/*.test.ts"
   },
   "keywords": [

pi-extensions/answer.ts

@@ -163,9 +163,11 @@ class QnAComponent implements Component {
 		const editorTheme: EditorTheme = {
 			borderColor: this.dim,
 			selectList: {
-				selectedBg: (s: string) => `\x1b[44m${s}\x1b[0m`,
-				matchHighlight: this.cyan,
-				itemSecondary: this.gray,
+				selectedPrefix: (s: string) => `\x1b[44m${s}\x1b[0m`,
+				selectedText: this.cyan,
+				description: this.gray,
+				scrollInfo: this.dim,
+				noMatch: this.dim,
 			},
 		};
 

pi-extensions/control.ts

@@ -472,7 +472,8 @@ function getMessagesSinceLastPrompt(ctx: ExtensionContext): ExtractedMessage[] {
 		if (entry.type === "message") {
 			const msg = entry.message;
 			if ("role" in msg && (msg.role === "user" || msg.role === "assistant")) {
-				const textParts = msg.content
+				const content = msg.content;
+				const textParts = (Array.isArray(content) ? content : [])
 					.filter((c): c is { type: "text"; text: string } => c.type === "text")
 					.map((c) => c.text);
 				if (textParts.length > 0) {
@@ -764,7 +765,8 @@ async function handleCommand(
 		return;
 	}
 
-	respond(false, command.type, undefined, `Unsupported command: ${command.type}`);
+	const commandType = (command as { type: string }).type;
+	respond(false, commandType, undefined, `Unsupported command: ${commandType}`);
 }
 
 // ============================================================================
@@ -868,12 +870,12 @@ async function sendRpcCommand(
 					// Handle response
 					if (msg.type === "response") {
 						if (msg.command === command.type) {
-							response = msg;
+							response = msg as RpcResponse;
 							// If not waiting for event, we're done
 							if (!waitForEvent) {
 								cleanup();
 								socket.end();
-								resolve({ response });
+								resolve({ response: msg as RpcResponse });
 								return;
 							}
 						}
@@ -1403,11 +1405,12 @@ Messages automatically include sender session info for replies. When you want a
 
 		renderResult(result, { expanded }, theme) {
 			const details = result.details as Record<string, unknown> | undefined;
-			const isError = result.isError === true;
+			const isError = (result as unknown as Record<string, unknown>).isError === true;
 
 			// Error case
 			if (isError || details?.error) {
-				const errorMsg = (details?.error as string) || result.content[0]?.type === "text" ? (result.content[0] as { type: "text"; text: string }).text : "Unknown error";
+				const errorMsg = (details?.error as string)
+					?? (result.content[0]?.type === "text" ? (result.content[0] as { type: "text"; text: string }).text : "Unknown error");
 				return new Text(theme.fg("error", "✗ ") + theme.fg("error", errorMsg), 0, 0);
 			}
 

pi-extensions/files.ts

@@ -159,7 +159,7 @@ const extractFileReferencesFromContent = (content: unknown): string[] => {
 };
 
 const extractFileReferencesFromEntry = (entry: SessionEntry): string[] => {
-	if (entry.type === "message") {
+	if (entry.type === "message" && "content" in entry.message) {
 		return extractFileReferencesFromContent(entry.message.content);
 	}
 

pi-extensions/git-rebase-master.ts

@@ -154,7 +154,7 @@ export default function gitRebaseMasterExtension(pi: ExtensionAPI) {
 			]);
 
 			if (rebaseCode === 0) {
-				ctx.ui.notify("Rebase completed successfully — no conflicts.", "success");
+				ctx.ui.notify("Rebase completed successfully — no conflicts.", "info");
 				return;
 			}
 

pi-extensions/kt/index.ts

@@ -24,6 +24,7 @@ import {
 	type ExtensionAPI,
 	type ExtensionContext,
 	type Theme,
+	type ThemeColor,
 } from "@mariozechner/pi-coding-agent";
 import { StringEnum } from "@mariozechner/pi-ai";
 import { Type } from "@sinclair/typebox";
@@ -165,8 +166,8 @@ async function withLock<T>(
 // ── Themed Rendering ───────────────────────────────────────────────────
 
 function renderTicketHeading(theme: Theme, t: TicketFrontMatter, currentSession?: string): string {
-	let iconColor: string;
-	let titleColor: string;
+	let iconColor: ThemeColor;
+	let titleColor: ThemeColor;
 	if (t.status === "closed") {
 		iconColor = "dim";
 		titleColor = "dim";
@@ -1140,7 +1141,7 @@ export default function ktExtension(pi: ExtensionAPI) {
 
 			if (nextPrompt) {
 				ctx.ui.setEditorText(nextPrompt);
-				rootTui?.requestRender();
+				(rootTui as TUI | null)?.requestRender();
 			}
 		},
 	});
@@ -1200,18 +1201,16 @@ export default function ktExtension(pi: ExtensionAPI) {
 			}
 
 			// Ask user how to proceed
-			const forkChoice = await ctx.ui.select(
-				"kt-run-all: Session strategy",
-				[
-					{ value: "fork-each", label: "Fork a new session for each ticket", description: "Isolated sessions, context injected between tickets" },
-					{ value: "same-session", label: "Work through all in this session", description: "Agent processes tickets sequentially in current session" },
-					{ value: "cancel", label: "Cancel" },
-				],
-			);
-
-			if (!forkChoice || forkChoice === "cancel") return;
-
-			if (forkChoice === "same-session") {
+			const forkOptions = [
+				"Fork a new session for each ticket",
+				"Work through all in this session",
+				"Cancel",
+			];
+			const forkChoice = await ctx.ui.select("kt-run-all: Session strategy", forkOptions);
+
+			if (!forkChoice || forkChoice === "Cancel") return;
+
+			if (forkChoice === "Work through all in this session") {
 				// Inject prompt to work through all tickets
 				const prompt =
 					`Work through these tickets in order, one at a time. For each ticket:\n` +

pi-extensions/loop.ts

@@ -219,7 +219,7 @@ export default function loopExtension(pi: ExtensionAPI): void {
 
 		pi.sendMessage({
 			customType: "loop",
-			content: loopState.prompt,
+			content: loopState.prompt ?? "",
 			display: true
 		}, {
 			deliverAs: "followUp",

pi-extensions/notify.ts

@@ -79,14 +79,15 @@ const formatNotification = (text: string | null): { title: string; body: string
 	return { title: "π", body };
 };
 
-export default function (pi: ExtensionAPI) {
+export default function notifyExtension(pi: ExtensionAPI) {
 	pi.on("agent_end", async (event) => {
 		const lastText = extractLastAssistantText(event.messages ?? []);
 		const { title, body } = formatNotification(lastText);
 		notify(title, body);
 	});
 
-	pi.events.on("waiting_for_input", (data: { question?: string }) => {
-		notify("π", data.question ?? "Waiting for input");
+	pi.events.on("waiting_for_input", (data: unknown) => {
+		const input = data as { question?: string } | undefined;
+		notify("π", input?.question ?? "Waiting for input");
 	});
 }

pi-extensions/plan-ask.ts

@@ -21,7 +21,7 @@
 
 import type { AgentMessage } from "@mariozechner/pi-agent-core";
 import type { AssistantMessage, TextContent } from "@mariozechner/pi-ai";
-import type { ExtensionAPI, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import type { ExtensionAPI, ExtensionContext, ThemeColor } from "@mariozechner/pi-coding-agent";
 
 // ── Types ────────────────────────────────────────────────────────────────
 
@@ -242,15 +242,17 @@ const DEFAULT_AGENT_TOOLS: string[] = ["read", "bash", "edit", "write"];
 
 // ── Status display ───────────────────────────────────────────────────────
 
-interface ModeDisplay {
+/** Display metadata for each mode — icon, label, and theme color. */
+export interface ModeDisplay {
 	icon: string;
 	label: string;
-	color: "success" | "info" | "warning";
+	color: ThemeColor;
 }
 
-const MODE_DISPLAY: Record<Mode, ModeDisplay> = {
+/** Per-mode display configuration used in the status bar and notifications. */
+export const MODE_DISPLAY: Record<Mode, ModeDisplay> = {
 	[AGENT]: { icon: "🤖", label: "agent", color: "success" },
-	[ASK]: { icon: "❓", label: "ask", color: "info" },
+	[ASK]: { icon: "❓", label: "ask", color: "accent" },
 	[PLAN]: { icon: "📋", label: "plan", color: "warning" },
 };
 
@@ -431,7 +433,7 @@ export default function planAskExtension(pi: ExtensionAPI) {
 
 		if (action === "Create tickets with /kt-create") {
 			setMode(AGENT, ctx);
-			ctx.ui.runCommand("kt-create");
+			pi.sendUserMessage("/kt-create");
 			return;
 		}
 
@@ -454,7 +456,7 @@ export default function planAskExtension(pi: ExtensionAPI) {
 				const { dirname } = await import("node:path");
 				await mkdir(dirname(path), { recursive: true });
 				await writeFile(path, planText, "utf-8");
-				ctx.ui.notify(`Plan saved to ${path}`, "success");
+				ctx.ui.notify(`Plan saved to ${path}`, "info");
 			} catch (err: unknown) {
 				const message = err instanceof Error ? err.message : String(err);
 				ctx.ui.notify(`Failed to save plan: ${message}`, "error");