Fix accidental removal of completion from series and publisher delegates

Author: kovidgoyal

src/calibre/gui2/library/delegates.py

@@ -342,28 +342,18 @@ def set_editor_data(self, editor, index):
 class TextDelegate(StyledItemDelegate, UpdateEditorGeometry, EditableTextDelegate):  # {{{
 
     use_title_sort = False
-
-    def __init__(self, parent):
-        '''
-        Delegate for text data. If auto_complete_function needs to return a list
-        of text items to auto-complete with. If the function is None no
-        auto-complete will be used.
-        '''
-        StyledItemDelegate.__init__(self, parent)
-        self.auto_complete_function = None
-
-    def set_auto_complete_function(self, f):
-        self.auto_complete_function = f
+    auto_complete_function_name = ''
 
     def create_editor(self, parent, option, index):
-        if self.auto_complete_function:
+        db = index.model().db
+        if self.auto_complete_function_name and (f := getattr(db, self.auto_complete_function_name, None)):
             if self.use_title_sort:
                 editor = EditWithComplete(parent, sort_func=title_sort)
             else:
                 editor = EditWithComplete(parent)
             editor.set_separator(None)
             editor.set_clear_button_enabled(False)
-            complete_items = [i[1] for i in self.auto_complete_function()]
+            complete_items = [i[1] for i in f()]
             editor.update_items_cache(complete_items)
         else:
             editor = EnLineEdit(parent)
@@ -382,6 +372,7 @@ def setModelData(self, editor, model, index):
 class SeriesDelegate(TextDelegate):  # {{{
 
     use_title_sort = True
+    auto_complete_function_name = 'all_series'
 
     def initStyleOption(self, option, index):
         TextDelegate.initStyleOption(self, option, index)

src/calibre/gui2/pin_columns.py

@@ -88,6 +88,7 @@ def create_delegates(self):
         self.cc_names_delegate = CompleteDelegate(self, '&', 'all_custom', True)
         self.series_delegate = SeriesDelegate(self)
         self.publisher_delegate = TextDelegate(self)
+        self.publisher_delegate.auto_complete_function_name = 'all_publishers'
         self.text_delegate = TextDelegate(self)
         self.cc_text_delegate = CcTextDelegate(self)
         self.cc_series_delegate = CcSeriesDelegate(self)