--single-instance means children inherit X props and environment

[madduck]

Hello,

I am using --single-instance consistently to reduce startup time. I now discovered that this means that new windows (X clients, i.e. when run kitty --single-instance again) within an instance group get spawned from within the first instance, inheriting from the primary instance:

• X properties like WM_CLASS
• Environment
• ….

To reproduce this:

1. Run MYVAR=one kitty --single-instance --name one
2. Run another: MYVAR=two kitty --single-instance

Observe that within the second terminal, $MYVAR == one, and it also has a WM_CLASS of ("one", "kitty").

It is possible to override the name, so passing --name two on the second means that the X prop will be "two" and not "one", but I wonder whether it shouldn't just fall back to default?

I understand --single-instance, I think. I am operating off the principle of least surprise. And since X props are per-X-window and not per-Kitty-instance, I would expect

1. that without --name, the default X prop is used;
2. the environment of the caller that caused the X window to spawn is used.

Thoughts?

[kovidgoyal]

These are both fixed in master