Merge pull request #44 from kpumuk/remove-nerd-font-glyph

Stop requiring a Nerd Font for a single glyph

Author: kpumuk

README.md

@@ -28,7 +28,7 @@
 > Latest installation instructions for different platforms are available on the [Lazykiq website](https://kpumuk.github.io/lazykiq/docs/getting-started/installation/).
 
 > [!NOTE]
-> Lazykiq uses special glyphs in the UI; without a Nerd Font in your terminal some characters may render incorrectly.
+> Lazykiq uses Unicode box-drawing and chart glyphs in the UI; a modern UTF-8 terminal font is recommended.
 
 You can download the latest release from the [Releases](https://github.com/kpumuk/lazykiq/releases) page for your platform.
 

doc/docs/getting-started/installation.md

@@ -15,7 +15,7 @@ Download the latest release for your platform from the
 [GitHub Releases page](https://github.com/kpumuk/lazykiq/releases).
 
 {{< callout context="note" title="Note" icon="outline/info-circle" >}}
-Lazykiq uses special glyphs in the UI; without a Nerd Font in your terminal some characters may render incorrectly.
+Lazykiq uses Unicode box-drawing and chart glyphs in the UI; a modern UTF-8 terminal font is recommended.
 {{< /callout >}}
 
 ## Homebrew Tap

internal/ui/app.go

@@ -193,9 +193,8 @@ func New(client sidekiq.API, version string, dangerousActionsEnabled bool, devTr
 		),
 		stackbar: stackbar.New(
 			stackbar.WithStyles(stackbar.Styles{
-				Bar:   styles.StackBar,
-				Item:  styles.StackItem,
-				Arrow: styles.StackArrow,
+				Bar:  styles.StackBar,
+				Item: styles.StackItem,
 			}),
 			stackbar.WithStack([]string{viewRegistry[viewDashboard].Name()}),
 		),

internal/ui/components/stackbar/stackbar.go

@@ -10,17 +10,15 @@ import (
 
 // Styles holds the styles needed by the stack bar.
 type Styles struct {
-	Bar   lipgloss.Style
-	Item  lipgloss.Style
-	Arrow lipgloss.Style
+	Bar  lipgloss.Style
+	Item lipgloss.Style
 }
 
 // DefaultStyles returns default styles for the stack bar.
 func DefaultStyles() Styles {
 	return Styles{
-		Bar:   lipgloss.NewStyle().Padding(0, 1),
-		Item:  lipgloss.NewStyle().Padding(0, 1),
-		Arrow: lipgloss.NewStyle(),
+		Bar:  lipgloss.NewStyle().Padding(0, 1),
+		Item: lipgloss.NewStyle().Padding(0, 1),
 	}
 }
 
@@ -122,5 +120,5 @@ func (m Model) View() string {
 }
 
 func formatLabel(styles Styles, label string) string {
-	return styles.Item.Render(label) + styles.Arrow.Render("")
+	return styles.Item.Render(label)
 }

internal/ui/components/stackbar/stackbar_test.go

@@ -11,9 +11,8 @@ import (
 
 func TestViewDimensions(t *testing.T) {
 	styles := Styles{
-		Bar:   lipgloss.NewStyle(),
-		Item:  lipgloss.NewStyle(),
-		Arrow: lipgloss.NewStyle(),
+		Bar:  lipgloss.NewStyle(),
+		Item: lipgloss.NewStyle(),
 	}
 
 	tests := map[string]struct {
@@ -47,19 +46,13 @@ func TestViewDimensions(t *testing.T) {
 }
 
 func TestViewFormatsStack(t *testing.T) {
-	const arrow = ""
 	labels := []string{"Errors", "Detail"}
-	items := []string{
-		labels[0] + arrow,
-		labels[1] + arrow,
-	}
-	expected := strings.Join(items, " ")
+	expected := strings.Join(labels, " ")
 
 	m := New(
 		WithStyles(Styles{
-			Bar:   lipgloss.NewStyle(),
-			Item:  lipgloss.NewStyle(),
-			Arrow: lipgloss.NewStyle(),
+			Bar:  lipgloss.NewStyle(),
+			Item: lipgloss.NewStyle(),
 		}),
 		WithStack(labels),
 	)
@@ -72,9 +65,8 @@ func TestViewFormatsStack(t *testing.T) {
 func TestGoldenStackBar(t *testing.T) {
 	m := New(
 		WithStyles(Styles{
-			Bar:   lipgloss.NewStyle(),
-			Item:  lipgloss.NewStyle(),
-			Arrow: lipgloss.NewStyle(),
+			Bar:  lipgloss.NewStyle(),
+			Item: lipgloss.NewStyle(),
 		}),
 		WithWidth(40),
 		WithStack([]string{"Errors", "Detail", "Payload"}),

internal/ui/components/stackbar/testdata/TestGoldenStackBar.golden

@@ -1 +1 @@
-Errors Detail Payload                
+Errors Detail Payload                   

internal/ui/theme/theme.go

@@ -201,10 +201,8 @@ type Styles struct {
 	NavBrand lipgloss.Style
 
 	// Stack bar
-	StackBar       lipgloss.Style
-	StackItem      lipgloss.Style
-	StackArrowLeft lipgloss.Style
-	StackArrow     lipgloss.Style
+	StackBar  lipgloss.Style
+	StackItem lipgloss.Style
 
 	// Content
 	ViewTitle lipgloss.Style
@@ -318,9 +316,6 @@ func NewStyles() Styles {
 			Background(t.StackBarBg).
 			Padding(0, 1),
 
-		StackArrow: lipgloss.NewStyle().
-			Foreground(t.StackBarBg),
-
 		// Content
 		ViewTitle: lipgloss.NewStyle().
 			Foreground(t.Primary).