Skip to content

Commit 34e0337

Browse files
committed
results for chrome 126
1 parent 274d3aa commit 34e0337

File tree

6 files changed

+217
-276
lines changed

6 files changed

+217
-276
lines changed

Diff for: webdriver-ts-results/src/App.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const App = () => {
4848

4949
const testEnvironmentInfo = (
5050
<p>
51-
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 125.0.6422.60
51+
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 126.0.6478.55
5252
(arm64) using the puppeteer benchmark driver with reduced tracing.
5353
</p>
5454
);

Diff for: webdriver-ts-results/src/results.ts

+214-214
Large diffs are not rendered by default.

Diff for: webdriver-ts/chromePreferences.json

-5
This file was deleted.

Diff for: webdriver-ts/results.json

+1-1
Large diffs are not rendered by default.

Diff for: webdriver-ts/src/benchmarkRunner.ts

+1-54
Original file line numberDiff line numberDiff line change
@@ -71,53 +71,6 @@ function forkAndCallBenchmark(
7171
});
7272
}
7373

74-
async function runBenchmakLoopStartup(
75-
framework: FrameworkData,
76-
benchmarkInfo: StartupBenchmarkInfo,
77-
benchmarkOptions: BenchmarkOptions
78-
): Promise<{ errors: string[]; warnings: string[] }> {
79-
let warnings: string[] = [];
80-
let errors: string[] = [];
81-
82-
let results: Array<StartupBenchmarkResult> = [];
83-
let count = benchmarkOptions.numIterationsForStartupBenchmark;
84-
benchmarkOptions.batchSize = 1;
85-
86-
let retries = 0;
87-
let done = 0;
88-
89-
console.log("runBenchmakLoopStartup", framework, benchmarkInfo);
90-
91-
while (done < count) {
92-
console.log("FORKING:", benchmarkInfo.id, "BatchSize", benchmarkOptions.batchSize);
93-
let res = await forkAndCallBenchmark(framework, benchmarkInfo, benchmarkOptions);
94-
if (Array.isArray(res.result)) {
95-
results = results.concat(res.result as StartupBenchmarkResult[]);
96-
} else {
97-
results.push(res.result);
98-
}
99-
if (res.warnings) {
100-
warnings = warnings.concat(res.warnings);
101-
}
102-
if (res.error) {
103-
errors.push(`Executing ${framework.uri} and benchmark ${benchmarkInfo.id} failed: ` + res.error);
104-
break;
105-
}
106-
done++;
107-
}
108-
if (config.WRITE_RESULTS) {
109-
await writeResults(benchmarkOptions.resultsDirectory, {
110-
framework: framework,
111-
benchmark: benchmarkInfo,
112-
results: results,
113-
type: BenchmarkType.STARTUP,
114-
});
115-
}
116-
return { errors, warnings };
117-
// } else {
118-
// return executeBenchmark(frameworks, keyed, frameworkName, benchmarkName, benchmarkOptions);
119-
}
120-
12174
async function runBenchmakLoopSize(
12275
framework: FrameworkData,
12376
benchmarkInfo: SizeBenchmarkInfo,
@@ -252,13 +205,7 @@ async function runBench(
252205
try {
253206
let result;
254207

255-
if (benchmarkInfos[j].type == BenchmarkType.STARTUP_MAIN) {
256-
result = await runBenchmakLoopStartup(
257-
runFrameworks[i],
258-
benchmarkInfos[j] as StartupBenchmarkInfo,
259-
benchmarkOptions
260-
);
261-
} else if (benchmarkInfos[j].type == BenchmarkType.SIZE_MAIN) {
208+
if (benchmarkInfos[j].type == BenchmarkType.SIZE_MAIN) {
262209
result = await runBenchmakLoopSize(
263210
runFrameworks[i],
264211
benchmarkInfos[j] as SizeBenchmarkInfo,

Diff for: webdriver-ts/src/puppeteerAccess.ts

-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ export async function startBrowser(benchmarkOptions: BenchmarkOptions): Promise<
133133
const browser = await puppeteer.launch({
134134
headless: false,
135135
executablePath: browserPath(benchmarkOptions),
136-
137136
args,
138137
dumpio: false,
139138
defaultViewport: {

0 commit comments

Comments
 (0)