Skip to content

Commit 3faf4a3

Browse files
committed
chrome 125 results, remove 0 waits
1 parent 895be5d commit 3faf4a3

File tree

6 files changed

+219
-230
lines changed

6 files changed

+219
-230
lines changed

Diff for: webdriver-ts-results/src/App.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const App = () => {
4848

4949
const testEnvironmentInfo = (
5050
<p>
51-
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 124.0.6367.91
51+
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 125.0.6422.60
5252
(arm64) using the puppeteer benchmark driver with reduced tracing.
5353
</p>
5454
);

Diff for: webdriver-ts-results/src/results.ts

+216-215
Large diffs are not rendered by default.

Diff for: webdriver-ts/results.json

+1-1
Large diffs are not rendered by default.

Diff for: webdriver-ts/src/benchmarksPuppeteer.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
BenchmarkImpl,
1111
MemBenchmarkInfo,
1212
} from "./benchmarksCommon.js";
13-
import { config, FrameworkData, puppeteerWait } from "./common.js";
13+
import { config, FrameworkData } from "./common.js";
1414
import {
1515
checkCountForSelector,
1616
checkElementContainsText,
@@ -44,14 +44,12 @@ export let benchRun = new (class extends CPUBenchmarkPuppeteer {
4444
await checkElementExists(page, "pierce/#run");
4545
for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
4646
await clickElement(page, "pierce/#run");
47-
await puppeteerWait();
4847
await checkElementContainsText(
4948
page,
5049
"pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
5150
(i * 1000 + 1).toFixed()
5251
);
5352
await clickElement(page, "pierce/#clear");
54-
await puppeteerWait();
5553
await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
5654
}
5755
}
@@ -73,7 +71,6 @@ export const benchReplaceAll = new (class extends CPUBenchmarkPuppeteer {
7371
await checkElementExists(page, "pierce/#run");
7472
for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
7573
await clickElement(page, "pierce/#run");
76-
await puppeteerWait();
7774
await checkElementContainsText(
7875
page,
7976
"pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
@@ -228,14 +225,12 @@ export const benchRunBig = new (class extends CPUBenchmarkPuppeteer {
228225
await checkElementExists(page, "pierce/#run");
229226
for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
230227
await clickElement(page, "pierce/#run");
231-
await puppeteerWait();
232228
await checkElementContainsText(
233229
page,
234230
"pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
235231
(i * 1000 + 1).toFixed()
236232
);
237233
await clickElement(page, "pierce/#clear");
238-
await puppeteerWait();
239234
await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
240235
}
241236
}

Diff for: webdriver-ts/src/common.ts

-1
Original file line numberDiff line numberDiff line change
@@ -179,4 +179,3 @@ export const wait = (delay = 1000) => {
179179
else return new Promise((res) => setTimeout(res, delay));
180180
};
181181

182-
export const puppeteerWait = () => wait(config.PUPPETEER_WAIT_MS);

Diff for: webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts

-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
ErrorAndWarning,
88
FrameworkData,
99
Config,
10-
puppeteerWait,
1110
wait,
1211
} from "./common.js";
1312
import { startBrowser } from "./puppeteerAccess.js";
@@ -93,11 +92,9 @@ async function runCPUBenchmark(
9392
// downloadThroughput: 780 * 1024 / 8, // 780 kb/s
9493
// uploadThroughput: 330 * 1024 / 8, // 330 kb/s
9594
// });
96-
await puppeteerWait();
9795

9896
console.log("initBenchmark");
9997
await initBenchmark(page, benchmark, framework);
100-
await puppeteerWait();
10198

10299
// let categories = ["blink.user_timing", "devtools.timeline", "disabled-by-default-devtools.timeline"];
103100
// "blink", "cc","toplevel","v8","benchmark","gpu","viz"
@@ -136,17 +133,14 @@ async function runCPUBenchmark(
136133
categories: categories,
137134
});
138135
await wait(50);
139-
await puppeteerWait();
140136

141137
await forceGC(page);
142-
await puppeteerWait();
143138

144139
console.log("runBenchmark");
145140
// let m1 = await page.metrics();
146141

147142
await runBenchmark(page, benchmark, framework);
148143

149-
await puppeteerWait();
150144
await wait(100);
151145
await page.tracing.stop();
152146
// let m2 = await page.metrics();

0 commit comments

Comments
 (0)