From da9eea817878296be02cba48c5aa1642ce40badc Mon Sep 17 00:00:00 2001 From: Willian Silva Date: Mon, 6 Apr 2026 19:09:09 -0300 Subject: [PATCH] Fix JS syntax error when locale contains double quotes in pipeline duplicate-name translation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace raw `{!! trans(...) !!}` output with `@json(trans(...))` in pipeline create and edit views. When translations (e.g. pt_BR) contain double quotes inside the string — such as 'O campo "Nome" não pode ser duplicado' — the raw output broke the surrounding JavaScript string literal, causing an `Uncaught SyntaxError: Unexpected identifier` in the browser. --- .../views/settings/pipelines/create.blade.php | 29 ++++++++++--------- .../views/settings/pipelines/edit.blade.php | 2 +- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/packages/Webkul/Admin/src/Resources/views/settings/pipelines/create.blade.php b/packages/Webkul/Admin/src/Resources/views/settings/pipelines/create.blade.php index 2b5b772fd7..a0e639c4da 100644 --- a/packages/Webkul/Admin/src/Resources/views/settings/pipelines/create.blade.php +++ b/packages/Webkul/Admin/src/Resources/views/settings/pipelines/create.blade.php @@ -157,23 +157,24 @@ class="flex gap-4 overflow-x-auto"
- @{{ element.name ? element.name : '@lang('admin::app.settings.pipelines.create.newly-added')'}} + @{{ element.name ? element.name : '@lang('admin::app.settings.pipelines.create.newly-added')'}}
- +
@@ -184,7 +185,7 @@ class="icon-move cursor-grab rounded-md p-1 text-2xl transition-all hover:bg-gra @lang('admin::app.settings.pipelines.create.name') - + - + @lang('admin::app.settings.pipelines.create.delete-stage')
@@ -287,7 +288,7 @@ class="secondary-button" return { stages: [{ 'id': 'stage_1', - 'code': 'new', + 'code': 'new', 'name': "@lang('admin::app.settings.pipelines.create.new-stage')", 'probability': 100 }, { @@ -346,7 +347,7 @@ class="secondary-button" } this.removeUniqueNameErrors(); - + this.$emitter.emit('add-flash', { type: 'success', message: "@lang('admin::app.settings.pipelines.create.stage-delete-success')" }); } }); @@ -388,7 +389,7 @@ class="secondary-button" }); if (filteredStages.length > 1) { - return "{!! trans('admin::app.settings.pipelines.create.duplicate-name') !!}"; + return @json(trans('admin::app.settings.pipelines.create.duplicate-name')); } this.removeUniqueNameErrors(); @@ -415,7 +416,7 @@ class="secondary-button" handleDragging(event) { const draggedElement = event.draggedContext.element; - + const relatedElement = event.relatedContext.element; return this.isDragable(draggedElement) && this.isDragable(relatedElement); @@ -424,4 +425,4 @@ class="secondary-button" }) @endPushOnce - \ No newline at end of file + diff --git a/packages/Webkul/Admin/src/Resources/views/settings/pipelines/edit.blade.php b/packages/Webkul/Admin/src/Resources/views/settings/pipelines/edit.blade.php index 160ca96952..73ef368646 100644 --- a/packages/Webkul/Admin/src/Resources/views/settings/pipelines/edit.blade.php +++ b/packages/Webkul/Admin/src/Resources/views/settings/pipelines/edit.blade.php @@ -338,7 +338,7 @@ class="secondary-button" }); if (filteredStages.length > 1) { - return "{!! trans('admin::app.settings.pipelines.create.duplicate-name') !!}"; + return @json(trans('admin::app.settings.pipelines.create.duplicate-name')); } this.removeUniqueNameErrors();