skipped tests with credentials from fork PRs (#104)

Signed-off-by: Tullio Sebastiani <tsebasti@redhat.com>

Author: tsebastiani

.github/workflows/test.yaml

@@ -73,6 +73,8 @@ jobs:
           ./staticcheck/staticcheck -checks all ./...
           
       - name: run test suite
+        env:
+          CI_FORK_PR: ${{ github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name }}
         run: |
          export USERID=$(id -u)
          go test -tags containers_image_openpgp -race -json -v  -coverprofile=coverage.out ./... 2>&1 | tee /tmp/gotest.log | gotestfmt
@@ -88,13 +90,15 @@ jobs:
           echo "TOTAL_COVERAGE=$COVERAGE" >> $GITHUB_ENV
 
       - name: check out doc repo
+        if: ${{ !github.event.pull_request.head.repo.fork }}
         uses: actions/checkout@v4
         with:
           repository: krkn-chaos/krkn-lib-docs
           path: krkn-lib-docs
           ssh-key: ${{ secrets.KRKN_LIB_DOCS_PRIV_KEY }}
 
       - name: push updated coverage badge
+        if: ${{ !github.event.pull_request.head.repo.fork }}
         env:
           COLOR: yellow
         run: |

pkg/provider/registryv2/scenario_provider_test.go

@@ -2,12 +2,14 @@ package registryv2
 
 import (
 	json_parser "encoding/json"
+	"os"
+	"testing"
+
 	krknctlconfig "github.com/krkn-chaos/krknctl/pkg/config"
 	"github.com/krkn-chaos/krknctl/pkg/provider"
 	"github.com/krkn-chaos/krknctl/pkg/provider/models"
+	"github.com/krkn-chaos/krknctl/pkg/utils"
 	"github.com/stretchr/testify/assert"
-	"os"
-	"testing"
 )
 
 func getConfig(t *testing.T) krknctlconfig.Config {
@@ -46,6 +48,7 @@ curl -X GET \
 */
 
 func TestScenarioProvider_GetRegistryImages_jwt(t *testing.T) {
+	utils.SkipTestIfForkPR(t)
 	config := getConfig(t)
 	p := ScenarioProvider{
 		provider.BaseScenarioProvider{
@@ -141,6 +144,7 @@ func TestScenarioProvider_GetRegistryImages_Htpasswd(t *testing.T) {
 }
 
 func TestScenarioProvider_GetScenarioDetail(t *testing.T) {
+	utils.SkipTestIfForkPR(t)
 	config := getConfig(t)
 	p := ScenarioProvider{
 		provider.BaseScenarioProvider{
@@ -169,7 +173,7 @@ func TestScenarioProvider_GetScenarioDetail(t *testing.T) {
 }
 
 func TestScenarioProvider_GetGlobalEnvironment(t *testing.T) {
-
+	utils.SkipTestIfForkPR(t)
 	config := getConfig(t)
 	p := ScenarioProvider{
 		provider.BaseScenarioProvider{
@@ -203,6 +207,7 @@ func TestScenarioProvider_GetGlobalEnvironment(t *testing.T) {
 }
 
 func TestScenarioProvider_ScaffoldScenarios(t *testing.T) {
+	utils.SkipTestIfForkPR(t)
 	config := getConfig(t)
 	p := ScenarioProvider{
 		provider.BaseScenarioProvider{

pkg/scenarioorchestrator/scenarioorchestratortest/common_test_functions.go

@@ -5,6 +5,14 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"os"
+	"os/user"
+	"path/filepath"
+	"strconv"
+	"strings"
+	"testing"
+	"time"
+
 	"github.com/krkn-chaos/krknctl/pkg/cache"
 	krknctlconfig "github.com/krkn-chaos/krknctl/pkg/config"
 	"github.com/krkn-chaos/krknctl/pkg/dependencygraph"
@@ -16,13 +24,6 @@ import (
 	"github.com/krkn-chaos/krknctl/pkg/scenarioorchestrator/utils"
 	krknctlutils "github.com/krkn-chaos/krknctl/pkg/utils"
 	"github.com/stretchr/testify/assert"
-	"os"
-	"os/user"
-	"path/filepath"
-	"strconv"
-	"strings"
-	"testing"
-	"time"
 )
 
 func CommonGetConfig(t *testing.T) krknctlconfig.Config {
@@ -83,28 +84,33 @@ func CommonTestScenarioOrchestratorRun(t *testing.T, so scenarioorchestrator.Sce
 	containerID, err := so.Run(registryURI+":"+scenario.Name, containerName, env, false, map[string]string{}, nil, ctx, nil)
 	assert.Nil(t, err)
 	assert.NotNil(t, containerID)
-
+	pr := providermodels.RegistryV2{}
 	//pulling image from private registry with token
-	quayToken := os.Getenv("QUAY_TOKEN")
-	pr := providermodels.RegistryV2{
-		RegistryURL:        "quay.io",
-		ScenarioRepository: "rh_ee_tsebasti/krkn-hub-private",
-		Token:              &quayToken,
-		SkipTLS:            true,
-	}
 
-	timestamp = time.Now().Unix()
-	containerName = fmt.Sprintf("%s-%s-%d%d", conf.ContainerPrefix, scenario.Name, timestamp, krknctlutils.RandomInt64(nil))
-	containerID, err = so.Run(pr.GetPrivateRegistryURI()+":"+scenario.Name, containerName, env, false, map[string]string{}, nil, ctx, &pr)
-	if so.GetContainerRuntime() == models.Docker {
-		if err != nil {
-			fmt.Println(err.Error())
+	if os.Getenv("CI_FORK_PR") == "false" {
+		quayToken := os.Getenv("QUAY_TOKEN")
+		pr = providermodels.RegistryV2{
+			RegistryURL:        "quay.io",
+			ScenarioRepository: "rh_ee_tsebasti/krkn-hub-private",
+			Token:              &quayToken,
+			SkipTLS:            true,
+		}
+
+		timestamp = time.Now().Unix()
+		containerName = fmt.Sprintf("%s-%s-%d%d", conf.ContainerPrefix, scenario.Name, timestamp, krknctlutils.RandomInt64(nil))
+		containerID, err = so.Run(pr.GetPrivateRegistryURI()+":"+scenario.Name, containerName, env, false, map[string]string{}, nil, ctx, &pr)
+		if so.GetContainerRuntime() == models.Docker {
+			if err != nil {
+				fmt.Println(err.Error())
+			}
+			assert.Nil(t, err)
+			assert.NotNil(t, containerID)
+		} else {
+			assert.NotNil(t, err)
+			assert.Equal(t, err.Error(), "token authentication not yet supported in podman")
 		}
-		assert.Nil(t, err)
-		assert.NotNil(t, containerID)
 	} else {
-		assert.NotNil(t, err)
-		assert.Equal(t, err.Error(), "token authentication not yet supported in podman")
+		t.Log("skipping quay private registry on fork PR for lack of credentials")
 	}
 
 	//pulling image from private registry with username and password

pkg/utils/utils_function.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"path/filepath"
 	"strings"
+	"testing"
 )
 
 func ExpandFolder(folder string, basePath *string) (*string, error) {
@@ -47,3 +48,10 @@ func RandomInt64(max *int64) int64 {
 	}
 	return bigRand.Int64()
 }
+
+func SkipTestIfForkPR(t *testing.T) {
+	t.Helper()
+	if os.Getenv("CI_FORK_PR") == "true" {
+		t.Skip("skipped on fork PR (no secrets / external repo)")
+	}
+}