Skip to content

Commit 2695f75

Browse files
committed
fix make build
1 parent 1a138cf commit 2695f75

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ ifeq ($(DIFF), 1)
2323
GIT_TREESTATE = "dirty"
2424
endif
2525

26-
LDFLAGS=-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=$(GIT_VERSION) \
26+
LDFLAGS="-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=$(GIT_VERSION) \
2727
-X sigs.k8s.io/release-utils/version.gitCommit=$(GIT_HASH) \
2828
-X sigs.k8s.io/release-utils/version.gitTreeState=$(GIT_TREESTATE) \
29-
-X sigs.k8s.io/release-utils/version.buildDate=$(BUILD_DATE)
29+
-X sigs.k8s.io/release-utils/version.buildDate=$(BUILD_DATE)"
3030

3131
WITH_GOFLAGS = GOFLAGS="$(GOFLAGS)"
3232

pkg/runtime/interfaces.go

-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ type ResourceDescriptor interface {
109109
// be evaluated before deciding whether to create a resource
110110
GetIncludeWhenExpressions() []string
111111

112-
113112
// IsNamespaced returns true if the resource is namespaced, and false if it's
114113
// cluster-scoped.
115114
IsNamespaced() bool

pkg/runtime/runtime_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -2644,7 +2644,6 @@ func (m *mockResource) GetIncludeWhenExpressions() []string {
26442644
return m.conditions
26452645
}
26462646

2647-
26482647
func (m *mockResource) IsNamespaced() bool {
26492648
return m.namespaced
26502649
}

0 commit comments

Comments
 (0)