Skip to content

Commit 45adaf5

Browse files
authored
Merge pull request #259 from amirahav/set-finalizers
Copy finalizers from observed to desired object on resource update
2 parents dc78f7d + cf49e5e commit 45adaf5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: pkg/controller/instance/controller_reconcile.go

+2
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,9 @@ func (igr *instanceGraphReconciler) updateResource(
270270
igr.instanceSubResourcesLabeler.ApplyLabels(desired)
271271

272272
// Apply changes to the resource
273+
// TODO: Handle annotations
273274
desired.SetResourceVersion(observed.GetResourceVersion())
275+
desired.SetFinalizers(observed.GetFinalizers())
274276
_, err = rc.Update(ctx, desired, metav1.UpdateOptions{})
275277
if err != nil {
276278
resourceState.State = "ERROR"

0 commit comments

Comments
 (0)