feat: enqueue instances on rgd update (#474)

* feat: enqueue instance objects after rgd update

Author: fabianburth

Diff for: pkg/dynamiccontroller/dynamic_controller.go

@@ -64,6 +64,7 @@ import (
 	"github.com/go-logr/logr"
 	"golang.org/x/time/rate"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apimachinery/pkg/types"
@@ -427,8 +428,16 @@ func (dc *DynamicController) StartServingGVK(ctx context.Context, gvr schema.Gro
 	_, exists := dc.informers.Load(gvr)
 	if exists {
 		// Even thought the informer is already registered, we should still
-		// still update the handler, as it might have changed.
+		// update the handler, as it might have changed.
 		dc.handlers.Store(gvr, handler)
+		// trigger reconciliation of the corresponding gvr's
+		objs, err := dc.kubeClient.Resource(gvr).Namespace("").List(ctx, metav1.ListOptions{})
+		if err != nil {
+			return fmt.Errorf("failed to list objects for GVR %s: %w", gvr, err)
+		}
+		for _, obj := range objs.Items {
+			dc.enqueueObject(&obj, "update")
+		}
 		return nil
 	}
 
@@ -441,7 +450,6 @@ func (dc *DynamicController) StartServingGVK(ctx context.Context, gvr schema.Gro
 		"",
 		nil,
 	)
-
 	informer := gvkInformer.ForResource(gvr).Informer()
 
 	// Set up event handlers

Diff for: pkg/dynamiccontroller/dynamic_controller_test.go

@@ -14,7 +14,10 @@ package dynamiccontroller
 
 import (
 	"context"
+	"fmt"
 	"io"
+	"maps"
+	"slices"
 	"testing"
 	"time"
 
@@ -152,3 +155,59 @@ func TestEnqueueObject(t *testing.T) {
 
 	assert.Equal(t, 1, dc.queue.Len())
 }
+
+func TestInstanceUpdatePolicy(t *testing.T) {
+	logger := noopLogger()
+
+	scheme := runtime.NewScheme()
+	gvr := schema.GroupVersionResource{Group: "test", Version: "v1", Resource: "tests"}
+	gvk := schema.GroupVersionKind{Group: "test", Version: "v1", Kind: "Test"}
+
+	objs := make(map[string]runtime.Object)
+
+	obj1 := &unstructured.Unstructured{}
+	obj1.SetGroupVersionKind(gvk)
+	obj1.SetNamespace("default")
+	obj1.SetName("test-object-1")
+	objs[obj1.GetNamespace()+"/"+obj1.GetName()] = obj1
+
+	obj2 := &unstructured.Unstructured{}
+	obj2.SetGroupVersionKind(gvk)
+	obj2.SetNamespace("test-namespace")
+	obj2.SetName("test-object-2")
+	objs[obj2.GetNamespace()+"/"+obj2.GetName()] = obj2
+
+	client := fake.NewSimpleDynamicClientWithCustomListKinds(scheme, map[schema.GroupVersionResource]string{
+		gvr: "TestList",
+	}, slices.Collect(maps.Values(objs))...)
+
+	dc := NewDynamicController(logger, Config{}, client)
+
+	handlerFunc := Handler(func(ctx context.Context, req controllerruntime.Request) error {
+		fmt.Println("reconciling instance", req)
+		return nil
+	})
+
+	// simulate initial creation of the resource graph
+	err := dc.StartServingGVK(context.Background(), gvr, handlerFunc)
+	assert.NoError(t, err)
+
+	// simulate reconciling the instances
+	for dc.queue.Len() > 0 {
+		item, _ := dc.queue.Get()
+		dc.queue.Done(item)
+		dc.queue.Forget(item)
+	}
+
+	// simulate updating the resource graph
+	err = dc.StartServingGVK(context.Background(), gvr, handlerFunc)
+	assert.NoError(t, err)
+
+	// check if the expected objects are queued
+	assert.Equal(t, dc.queue.Len(), 2)
+	for dc.queue.Len() > 0 {
+		name, _ := dc.queue.Get()
+		_, ok := objs[name.NamespacedKey]
+		assert.True(t, ok)
+	}
+}