From 2695f758c79e596d4a63ebb6cd127d050ed0e8dc Mon Sep 17 00:00:00 2001 From: Scott Nichols Date: Tue, 1 Apr 2025 14:41:45 -0700 Subject: [PATCH] fix make build --- Makefile | 4 ++-- pkg/runtime/interfaces.go | 1 - pkg/runtime/runtime_test.go | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 0fd65038..3e6f067c 100644 --- a/Makefile +++ b/Makefile @@ -23,10 +23,10 @@ ifeq ($(DIFF), 1) GIT_TREESTATE = "dirty" endif -LDFLAGS=-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=$(GIT_VERSION) \ +LDFLAGS="-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=$(GIT_VERSION) \ -X sigs.k8s.io/release-utils/version.gitCommit=$(GIT_HASH) \ -X sigs.k8s.io/release-utils/version.gitTreeState=$(GIT_TREESTATE) \ - -X sigs.k8s.io/release-utils/version.buildDate=$(BUILD_DATE) + -X sigs.k8s.io/release-utils/version.buildDate=$(BUILD_DATE)" WITH_GOFLAGS = GOFLAGS="$(GOFLAGS)" diff --git a/pkg/runtime/interfaces.go b/pkg/runtime/interfaces.go index 21e3fda7..6c834725 100644 --- a/pkg/runtime/interfaces.go +++ b/pkg/runtime/interfaces.go @@ -109,7 +109,6 @@ type ResourceDescriptor interface { // be evaluated before deciding whether to create a resource GetIncludeWhenExpressions() []string - // IsNamespaced returns true if the resource is namespaced, and false if it's // cluster-scoped. IsNamespaced() bool diff --git a/pkg/runtime/runtime_test.go b/pkg/runtime/runtime_test.go index d30b0b71..bc357344 100644 --- a/pkg/runtime/runtime_test.go +++ b/pkg/runtime/runtime_test.go @@ -2644,7 +2644,6 @@ func (m *mockResource) GetIncludeWhenExpressions() []string { return m.conditions } - func (m *mockResource) IsNamespaced() bool { return m.namespaced }