fix move partial failure reporting, deduplicate formatDate, clean JSON output, add test coverage

Author: krodak

src/commands/move.ts

@@ -20,8 +20,19 @@ export async function moveTask(config: Config, taskId: string, opts: MoveOptions
   }
 
   if (opts.remove) {
-    await client.removeTaskFromList(taskId, opts.remove)
-    messages.push(`Removed ${taskId} from list ${opts.remove}`)
+    try {
+      await client.removeTaskFromList(taskId, opts.remove)
+      messages.push(`Removed ${taskId} from list ${opts.remove}`)
+    } catch (err) {
+      if (messages.length > 0) {
+        const reason = err instanceof Error ? err.message : String(err)
+        throw new Error(
+          `${messages.join('; ')}; but failed to remove from list ${opts.remove}: ${reason}`,
+          { cause: err },
+        )
+      }
+      throw err
+    }
   }
 
   return messages.join('; ')

src/commands/tasks.ts

@@ -1,6 +1,7 @@
 import { ClickUpClient } from '../api.js'
 import type { Task, TaskFilters } from '../api.js'
 import type { Config } from '../config.js'
+import { formatDate } from '../date.js'
 import { isTTY, shouldOutputJson } from '../output.js'
 import { formatTasksMarkdown } from '../markdown.js'
 import { interactiveTaskPicker, showDetailsAndOpen } from '../interactive.js'
@@ -35,11 +36,7 @@ function isInitiative(task: Task): boolean {
 
 function formatDueDate(ms: string | null | undefined): string {
   if (!ms) return ''
-  const d = new Date(Number(ms))
-  const year = d.getUTCFullYear()
-  const month = String(d.getUTCMonth() + 1).padStart(2, '0')
-  const day = String(d.getUTCDate()).padStart(2, '0')
-  return `${year}-${month}-${day}`
+  return formatDate(ms)
 }
 
 export function summarize(task: Task): TaskSummary {

src/date.ts

@@ -0,0 +1,7 @@
+export function formatDate(ms: string | number): string {
+  const d = new Date(Number(ms))
+  const year = d.getUTCFullYear()
+  const month = String(d.getUTCMonth() + 1).padStart(2, '0')
+  const day = String(d.getUTCDate()).padStart(2, '0')
+  return `${year}-${month}-${day}`
+}

src/index.ts

@@ -466,7 +466,13 @@ program
       const config = loadConfig()
       const message = await manageDependency(config, taskId, opts)
       if (shouldOutputJson(opts.json ?? false)) {
-        console.log(JSON.stringify({ taskId, ...opts, message }, null, 2))
+        console.log(
+          JSON.stringify(
+            { taskId, on: opts.on, blocks: opts.blocks, remove: opts.remove, message },
+            null,
+            2,
+          ),
+        )
       } else {
         console.log(message)
       }
@@ -484,7 +490,7 @@ program
       const config = loadConfig()
       const message = await moveTask(config, taskId, opts)
       if (shouldOutputJson(opts.json ?? false)) {
-        console.log(JSON.stringify({ taskId, ...opts, message }, null, 2))
+        console.log(JSON.stringify({ taskId, to: opts.to, remove: opts.remove, message }, null, 2))
       } else {
         console.log(message)
       }

src/markdown.ts

@@ -2,6 +2,7 @@ import type { Task } from './api.js'
 import type { TaskSummary } from './commands/tasks.js'
 import type { CommentSummary } from './commands/comments.js'
 import type { ListSummary } from './commands/lists.js'
+import { formatDate } from './date.js'
 
 export interface MarkdownColumn<T> {
   key: keyof T & string
@@ -73,14 +74,6 @@ export function formatGroupedTasksMarkdown(
   return sections.join('\n\n')
 }
 
-function formatDate(ms: string): string {
-  const d = new Date(Number(ms))
-  const year = d.getUTCFullYear()
-  const month = String(d.getUTCMonth() + 1).padStart(2, '0')
-  const day = String(d.getUTCDate()).padStart(2, '0')
-  return `${year}-${month}-${day}`
-}
-
 function formatDuration(ms: number): string {
   const totalMinutes = Math.floor(ms / 60000)
   const hours = Math.floor(totalMinutes / 60)

tests/unit/commands/inbox.test.ts

@@ -104,6 +104,23 @@ describe('fetchInbox', () => {
     expect(result).toHaveLength(0)
   })
 
+  it('passes includeClosed to getMyTasks when set', async () => {
+    mockGetMyTasks.mockResolvedValue([])
+    const { fetchInbox } = await import('../../../src/commands/inbox.js')
+    await fetchInbox({ apiToken: 'pk_t', teamId: 'team1' }, 30, { includeClosed: true })
+    expect(mockGetMyTasks).toHaveBeenCalledWith('team1', { subtasks: true, includeClosed: true })
+  })
+
+  it('does not pass includeClosed when not set', async () => {
+    mockGetMyTasks.mockResolvedValue([])
+    const { fetchInbox } = await import('../../../src/commands/inbox.js')
+    await fetchInbox({ apiToken: 'pk_t', teamId: 'team1' }, 30)
+    expect(mockGetMyTasks).toHaveBeenCalledWith('team1', {
+      subtasks: true,
+      includeClosed: undefined,
+    })
+  })
+
   it('includes date_updated in returned summaries', async () => {
     const now = Date.now()
     mockGetMyTasks.mockResolvedValue([makeTask('t1', now - 1000)])

tests/unit/commands/move.test.ts

@@ -44,6 +44,23 @@ describe('moveTask', () => {
     expect(msg).toContain('Removed')
   })
 
+  it('reports partial success when add succeeds but remove fails', async () => {
+    mockRemoveTaskFromList.mockRejectedValueOnce(new Error('list not found'))
+    const { moveTask } = await import('../../../src/commands/move.js')
+    await expect(
+      moveTask({ apiToken: 'pk_t', teamId: 'tm' }, 'task1', { to: 'list2', remove: 'list3' }),
+    ).rejects.toThrow(/Added task1 to list list2.*failed to remove.*list not found/)
+    expect(mockAddTaskToList).toHaveBeenCalledWith('task1', 'list2')
+  })
+
+  it('throws original error when remove fails without prior add', async () => {
+    mockRemoveTaskFromList.mockRejectedValueOnce(new Error('list not found'))
+    const { moveTask } = await import('../../../src/commands/move.js')
+    await expect(
+      moveTask({ apiToken: 'pk_t', teamId: 'tm' }, 'task1', { remove: 'list3' }),
+    ).rejects.toThrow('list not found')
+  })
+
   it('throws when neither --to nor --remove is provided', async () => {
     const { moveTask } = await import('../../../src/commands/move.js')
     await expect(moveTask({ apiToken: 'pk_t', teamId: 'tm' }, 'task1', {})).rejects.toThrow('--to')

tests/unit/commands/overdue.test.ts

@@ -35,6 +35,20 @@ describe('fetchOverdueTasks', () => {
     mockGetMe.mockReset().mockResolvedValue({ id: 42, username: 'me' })
   })
 
+  it('passes includeClosed to getMyTasks when set', async () => {
+    mockGetMyTasks.mockResolvedValue([])
+    const { fetchOverdueTasks } = await import('../../../src/commands/overdue.js')
+    await fetchOverdueTasks({ apiToken: 'pk_t', teamId: 'team1' }, { includeClosed: true })
+    expect(mockGetMyTasks).toHaveBeenCalledWith('team1', { includeClosed: true })
+  })
+
+  it('does not pass includeClosed when not set', async () => {
+    mockGetMyTasks.mockResolvedValue([])
+    const { fetchOverdueTasks } = await import('../../../src/commands/overdue.js')
+    await fetchOverdueTasks({ apiToken: 'pk_t', teamId: 'team1' })
+    expect(mockGetMyTasks).toHaveBeenCalledWith('team1', { includeClosed: undefined })
+  })
+
   it('returns tasks with due_date in the past', async () => {
     const pastDue = String(now - 24 * 60 * 60 * 1000)
     mockGetMyTasks.mockResolvedValue([makeTask('t1', 'to do', { due_date: pastDue })])

tests/unit/markdown.test.ts

@@ -276,6 +276,27 @@ describe('formatTaskDetailMarkdown', () => {
     expect(result.indexOf('## Description')).toBeGreaterThan(result.indexOf('**ID:**'))
   })
 
+  it('prefers markdown_content over description', () => {
+    const task: Task = {
+      ...fullTask,
+      description: 'plain text fallback',
+      markdown_content: '# Rich **markdown** content',
+    }
+    const result = formatTaskDetailMarkdown(task)
+    expect(result).toContain('# Rich **markdown** content')
+    expect(result).not.toContain('plain text fallback')
+  })
+
+  it('falls back to description when markdown_content is absent', () => {
+    const task: Task = {
+      ...fullTask,
+      description: 'plain description',
+      markdown_content: undefined,
+    }
+    const result = formatTaskDetailMarkdown(task)
+    expect(result).toContain('plain description')
+  })
+
   it('omits missing fields for a minimal task', () => {
     const minimal: Task = {
       id: 'min1',