analysis code may incorrect?

[BinglunWang]

Hi,

I just kindly find your analysis code may have some problems.
Like code[:,2] = -c1[1]*z

you can compare code in this link
https://github.com/NVlabs/tiny-cuda-nn/blob/master/include/tiny-cuda-nn/encodings/spherical_harmonics.h

[ksang]

Yes, I think you are right,
The reason is when I implemented this, I was refering the wikipedia source: https://en.wikipedia.org/wiki/Table_of_spherical_harmonics#Real_spherical_harmonics
And seems that dropped minus signs for those basis functions.

Thanks for pointing out, will update and possibly add a code gen to do that.

[BinglunWang]

Hi

Yes, I think you are right, The reason is when I implemented this, I was refering the wikipedia source: https://en.wikipedia.org/wiki/Table_of_spherical_harmonics#Real_spherical_harmonics And seems that dropped minus signs for those basis functions.

Thanks for pointing out, will update and possibly add a code gen to do that.

Sorry I clicked the 'closed this as completed'
No worries. I modified it as a fork of this repo.

Cheers,
Binglun