Skip to content

Commit 473fff4

Browse files
feat: support grpc future compatibility and update .pb.go files (#22)
#### Motivation The gRPC go tools support future proofing server implementations to changes to the .proto spec by embedding an "Unimplemented" type. We initially disabled this feature, but want to enable it now. Another benefit of this is that we do not need "dummy" implementations of functions just to meet the required interface. This allows us to remove the optional `PredictModelSize` and `ModelSize` functions from the adapters. References: - https://github.com/grpc/grpc-go/tree/master/cmd/protoc-gen-go-grpc#future-proofing-services #### Modifications - recompile .proto files without `require_unimplemented_servers=false` (this also changed the generated package names due to a change in protoc versions) - update adapter gRPC Server Services to embed the generated "Unimplemented" types to support future proofing - remove unused `PredictModelSize` and `ModelSize` functions from adapter grpc servers - embedding Unimplemented makes this possible without breaking the required interface - these remain in the puller server because it is meant to proxy to another model runtime - removed the unused `internal/proto/mlserver-modelrepo` package; `mlserver/modelrepo` is used instead - move the copy of `model_repository.proto` from `mlserver-modelrepo` to `mlserver/modelrepo` Signed-off-by: Travis Johnson <[email protected]>
1 parent 0b01f02 commit 473fff4

File tree

23 files changed

+124
-908
lines changed

23 files changed

+124
-908
lines changed

internal/proto/kfserving-predict-v2/inference.pb.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/proto/kfserving-predict-v2/inference_grpc.pb.go

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)