Skip to content

Commit fa804e9

Browse files
committed
clean up cmakefile a little bit more.
1 parent 0ec15bc commit fa804e9

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

CMakeLists.txt

+12-11
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ project("mpw-shell")
66
set (PROJECT_TYPE "CXX")
77
set (PROJECT_NAME "MPW Shell")
88

9+
10+
# -std=c++14
11+
set(CMAKE_CXX_STANDARD 14)
12+
set(CMAKE_CXX_STANDARD_REQUIRED TRUE)
13+
set(CMAKE_CXX_EXTENSIONS FALSE)
14+
15+
916
#
1017
# build config.h
1118
#
@@ -24,22 +31,20 @@ CHECK_LIBRARY_EXISTS(history add_history "" HAVE_LIBHISTORY)
2431
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h)
2532

2633

27-
28-
29-
set(CMAKE_CXX_FLAGS "-g -Wall -Wno-unused-variable -Wno-multichar -O1")
34+
add_compile_options(-g -Wall -Wno-unused-variable -Wno-multichar -O1)
3035

3136
if(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
32-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-const-variable ")
37+
add_compile_options(-Wno-unused-const-variable)
3338
endif()
3439

3540

3641
if(${CMAKE_CXX_COMPILER_ID} MATCHES "GNU")
37-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-but-set-variable")
42+
add_compile_options(-Wno-unused-but-set-variable)
3843
endif()
3944

4045

41-
42-
add_definitions(-I ${CMAKE_SOURCE_DIR}/ -I ${CMAKE_CURRENT_BINARY_DIR}/ )
46+
include_directories(${CMAKE_SOURCE_DIR})
47+
include_directories(${CMAKE_CURRENT_BINARY_DIR})
4348

4449
# from https://github.com/gsauthof/cmake-ragel
4550
macro(RAGEL_TARGET Name Input Output)
@@ -117,10 +122,6 @@ elseif(HAVE_LIBREADLINE)
117122
endif()
118123

119124

120-
# all this for -std=c++14
121-
set_property (TARGET mpw-shell PROPERTY CXX_STANDARD 14)
122-
set_property (TARGET mpw-shell PROPERTY CXX_STANDARD_REQUIRED TRUE)
123-
set_property (TARGET mpw-shell PROPERTY CXX_EXTENSIONS FALSE)
124125

125126
# create a symlink for mpw-make
126127
add_custom_command(

0 commit comments

Comments
 (0)