More clean up of code warnings.

Author: kshetline

e2e/app.po.ts

@@ -1,3 +1,4 @@
+// noinspection ES6UnusedImports
 import { browser, by, element } from 'protractor';
 
 export class AppPage {

protractor.conf.js

@@ -17,12 +17,13 @@ exports.config = {
   jasmineNodeOpts: {
     showColors: true,
     defaultTimeoutInterval: 30000,
-    print: function() {}
+    "print": function() {}
   },
-  onPrepare() {
+  "onPrepare": () => {
     require('ts-node').register({
       project: 'e2e/tsconfig.e2e.json'
     });
+    // noinspection JSCheckFunctionSignatures
     jasmine.getEnv().addReporter(new SpecReporter({ spec: { displayStacktrace: true } }));
   }
 };

src/app/app.service.ts

@@ -119,9 +119,9 @@ export class AppService {
   private defaultLocation: Location = new Location('(Greenwich Observatory)', 51.47, 0, 'UT');
   private _location = new BehaviorSubject<Location>(this.defaultLocation);
   private locationObserver: Observable<Location> = this._location.asObservable();
-  private _locations: Location[] = [];
+  private readonly _locations: Location[] = [];
   private _solarSystem = new SolarSystem();
-  private _starCatalog: StarCatalog;
+  private readonly _starCatalog: StarCatalog;
   private _starsReady = new BehaviorSubject<boolean>(false);
   private starsReadyObserver: Observable<boolean> = this._starsReady.asObservable();
   private _asteroidsReady = new BehaviorSubject<boolean>(false);
@@ -130,8 +130,8 @@ export class AppService {
   private currentTabObserver: Observable<CurrentTab> = this._currentTab.asObservable();
   private settingsSource = new Subject<UserSetting>();
   private settingsObserver: Observable<UserSetting> = this.settingsSource.asObservable();
-  private allSettings: {[view: string]: {[setting: string]: boolean | number | string}} = {};
-  private debouncedSaveSettings: () => void;
+  private readonly allSettings: {[view: string]: {[setting: string]: boolean | number | string}} = {};
+  private readonly debouncedSaveSettings: () => void;
   private knownIanaTimezones: Set<string>;
   private _northAzimuth = false;
   private _defaultTab = CurrentTab.SKY;
@@ -143,9 +143,9 @@ export class AppService {
   private _nativeDateTime = false;
   private _showNativeInputDialog = false;
   private _warningNativeDateTime = false;
-  private hostname: string;
-  private port: number;
-  private localTesting: boolean;
+  private readonly hostname: string;
+  private readonly port: number;
+  private readonly localTesting: boolean;
 
   constructor(astroDataService: AstroDataService, private httpClient: HttpClient, private _sanitizer: DomSanitizer,
               private router: Router) {
@@ -314,6 +314,7 @@ export class AppService {
   set currentTab(newTab: CurrentTab) {
     if (this._currentTab.getValue() !== newTab) {
       this._currentTab.next(newTab);
+      // noinspection JSIgnoredPromiseFromCall
       this.router.navigate(['/' + tabNames[this._currentTab.getValue()]]);
     }
   }

src/app/svc/generic-planetary-view.directive.ts

@@ -179,7 +179,7 @@ export abstract class GenericPlanetaryViewDirective extends GenericViewDirective
   protected topocentricMoon = false;
   protected northAzimuth = false;
 
-  constructor(protected appService: AppService, protected tabId: CurrentTab) {
+  protected constructor(protected appService: AppService, protected tabId: CurrentTab) {
     super(appService, tabId);
 
     this.brightenStars(false);

src/app/svc/generic-sky-view.directive.ts

@@ -80,7 +80,7 @@ export abstract class GenericSkyViewDirective extends GenericPlanetaryViewDirect
   protected showConstellations = false;
   protected showDimStars = false;
 
-  constructor(appService: AppService, tabId: CurrentTab) {
+  protected constructor(appService: AppService, tabId: CurrentTab) {
     super(appService, tabId);
   }
 
@@ -139,7 +139,7 @@ export abstract class GenericSkyViewDirective extends GenericPlanetaryViewDirect
         if (!pt)
           break;
 
-        if (!breakLine)
+        if (!breakLine) // noinspection JSUnusedAssignment
           outOfView = outOfView || !this.drawSkyPlotLine(pt, lastPt, dc, NONPLANET.CONSTELLATIONS);
 
         if (nextIsAnchor) {

src/app/svc/generic-view.directive.ts

@@ -368,7 +368,7 @@ export abstract class GenericViewDirective implements AfterViewInit {
   }
 
   onMouseMove(event: MouseEvent): void {
-    if (this.goodDragStart || !this.dragging)
+    if (this.goodDragStart || !this.dragging) // noinspection JSDeprecatedSymbols (for `which`)
       this.handleMouseMove(event.offsetX, event.offsetY, !!((event.buttons & 0x01) || (this.isSafari && (event.which & 0x01))));
   }
 

src/app/svc/planet-drawer.ts

@@ -39,7 +39,7 @@ export abstract class PlanetDrawer {
   protected w2: number;
   protected h2: number;
 
-  constructor(protected baseImage: HTMLImageElement, protected flattening: number, protected defaultColor: string) {
+  protected constructor(protected baseImage: HTMLImageElement, protected flattening: number, protected defaultColor: string) {
     if (baseImage) {
       this.scaledCylinderCanvas = <HTMLCanvasElement> <any> document.createElement('canvas');
       this.scaledCylinderCanvas.width = 1;
@@ -55,10 +55,12 @@ export abstract class PlanetDrawer {
     return 0.0;
   }
 
+  // noinspection JSUnusedGlobalSymbols
   hasImage(): boolean {
     return !!this.baseImage;
   }
 
+  // noinspection JSUnusedGlobalSymbols
   resetCachedTime(): void {
     this.lastTime = Number.MAX_VALUE;
   }

src/app/svc/svc-atlas.service.ts

@@ -70,9 +70,9 @@ export class SvcAtlasService {
   private static states: string[];
   private static statesPromise: Promise<string[]>;
 
-  private hostname: string;
-  private port: number;
-  private localTesting: boolean;
+  private readonly hostname: string;
+  private readonly port: number;
+  private readonly localTesting: boolean;
   private lastPing = -Number.MAX_SAFE_INTEGER;
 
   constructor(private httpClient: HttpClient) {

src/app/svc/svc-calendar-view/svc-calendar-view.component.ts

@@ -108,7 +108,7 @@ export class SvcCalendarViewComponent implements AfterViewInit {
   private equisolstice = true;
   private dailyMoonPhase = true;
   private dailyDaylight = true;
-  private throttledResize: () => void;
+  private readonly throttledResize: () => void;
   private eventFinder = new EventFinder();
   private moonDrawer: MoonDrawer;
 

src/app/svc/svc-change-location-dialog/svc-change-location-dialog.component.ts

@@ -105,6 +105,7 @@ export class SvcChangeLocationDialogComponent {
   }
 
   onKey(event: KeyboardEvent): void {
+    // noinspection JSDeprecatedSymbols (for `keyCode`)
     if (event.keyCode === 13)
       this.goToLocation();
   }