Update tslint rules with Angular-specific rules, adjust other rules.

kshetline · kshetline · commit beb65780e035 · 2019-06-09T21:59:43.000-04:00
diff --git a/src/app/app.component.html b/src/app/app.component.html
@@ -57,7 +57,7 @@ <h2>Sky View Café NP</h2>
       </div>
     </div>
     <div class="lower-panel flex-container" fxFlex="100%" fxLayout="row" fxLayoutAlign="start stretch" fxLayoutGap="4px">
-      <ks-tab-view fxFlex="1 0 auto" (onChange)="tabChanged($event)" [activeTab]="selectedTab">
+      <ks-tab-view fxFlex="1 0 auto" (change)="tabChanged($event)" [activeTab]="selectedTab">
         <ks-tab header="Sky">
           <svc-sky-view></svc-sky-view>
         </ks-tab>
diff --git a/src/app/svc/generic-planetary-view.ts b/src/app/svc/generic-planetary-view.ts
@@ -1,5 +1,5 @@
 /*
-  Copyright © 2017-2018 Kerry Shetline, kerry@shetline.com.
+  Copyright © 2017-2019 Kerry Shetline, kerry@shetline.com.
 
   This code is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -152,6 +152,7 @@ const PLANET_EXTRA_SPAN     = 2;
 const STAR_REDUCED_SPAN     = 2;
 export const FAR_AWAY = 999999;
 
+// tslint:disable-next-line:variable-name
 const DIMMEST_AT_SCALE_1x1_STAR_IMAGE_INDEX = 100;
 
 const opacitiesOfWhite: string[] = [];
diff --git a/src/app/svc/generic-sky-view.ts b/src/app/svc/generic-sky-view.ts
@@ -53,10 +53,14 @@ export const BRIGHT_STAR_LIMIT = 1.5;
   // stars anyway because of its importance for orientation.
 export const POLARIS_FK5_NUM = 907;
 
+// tslint:disable-next-line:variable-name
 const SCALE_WHERE_BRIGHTEST_STAR_IS_3x3 = 0.0026;
+// tslint:disable-next-line:variable-name
 const DIMMEST_ALLOWED_1x1_STAR_IMAGE_INDEX  = 33;
 // const DIMMEST_AT_SCALE_1x1_STAR_IMAGE_INDEX = 100;
+// tslint:disable-next-line:variable-name
 const BRIGHTEST_1x1_STAR_IMAGE_INDEX        = 500;
+// tslint:disable-next-line:variable-name
 const BRIGHTEST_3x3_STAR_IMAGE_INDEX        = 1500;
 
 const opacitiesOfWhite: string[] = [];
diff --git a/src/app/svc/svc-change-location-dialog/svc-change-location-dialog.component.ts b/src/app/svc/svc-change-location-dialog/svc-change-location-dialog.component.ts
@@ -34,14 +34,14 @@ export class SvcChangeLocationDialogComponent {
   private _visible = false;
   private _latitude: number;
   private _longitude: number;
-  private _timezone;
+  private _timezone: string;
   private hourOffset: number;
 
   formattedLatitude: string;
   formattedLongitude: string;
   formattedHourOffset: string;
   zoneChoice = '0';
-  currentZone;
+  currentZone: string;
 
   @Input() get visible(): boolean { return this._visible; }
   set visible(isVisible: boolean) {
diff --git a/src/app/svc/svc-ecliptic-view/svc-ecliptic-view.component.ts b/src/app/svc/svc-ecliptic-view/svc-ecliptic-view.component.ts
@@ -1,5 +1,5 @@
 /*
-  Copyright © 2017-2018 Kerry Shetline, kerry@shetline.com.
+  Copyright © 2017-2019 Kerry Shetline, kerry@shetline.com.
 
   This code is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
diff --git a/src/app/svc/svc-generic-options.component.ts b/src/app/svc/svc-generic-options.component.ts
@@ -38,7 +38,7 @@ export class SvcGenericOptionsComponent {
     {label: 'All asteroids and comets', value: ADDITIONALS.ALL}
   ];
 
-  constructor(protected appService: AppService, protected viewName) {
+  constructor(protected appService: AppService, protected viewName: string) {
     this.asteroidsReady = appService.asteroidsReady;
 
     if (!this.asteroidsReady) {
diff --git a/src/app/svc/svc-insolation-view/svc-insolation-view.component.ts b/src/app/svc/svc-insolation-view/svc-insolation-view.component.ts
@@ -183,7 +183,7 @@ export class SvcInsolationViewComponent extends GenericView implements AfterView
       let y0 = this.lastPlotY;
       let timedOut = false;
 
-    outerLoop:
+      outerLoop:
       for (let plotSize = this.lastPlotSize; plotSize >= 1; plotSize /= 2) {
         for (let y = y0; y < this.daysInYear; y += plotSize) {
           let time_jdu = this.baseTime + y + 2.5 / MINS_PER_DAY - 5.0 / MINS_PER_DAY * plotSize;
diff --git a/src/app/svc/svc-map-view/svc-map-view.component.ts b/src/app/svc/svc-map-view/svc-map-view.component.ts
@@ -1,5 +1,5 @@
 /*
-  Copyright © 2017 Kerry Shetline, kerry@shetline.com.
+  Copyright © 2017-2019 Kerry Shetline, kerry@shetline.com.
 
   This code is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -86,8 +86,8 @@ export class SvcMapViewComponent extends GenericView implements AfterViewInit {
 
   private xOffset: number;
   private mapYOffset: number;
-  private mapWidth;
-  private mapHeight;
+  private mapWidth: number;
+  private mapHeight: number;
   private moonShadowPts: number[];
   private lastSunLatitude = 0;
   private lastSunLongitude = 0;
diff --git a/src/app/svc/svc-moons-view/svc-moons-view.component.ts b/src/app/svc/svc-moons-view/svc-moons-view.component.ts
@@ -218,7 +218,7 @@ export class SvcMoonsViewComponent extends GenericPlanetaryView implements After
     let planetShown = false;
     let colorOfMoon: string = null;
     const pt = <Point> {};
-    let number = '', name = '', longName = '';
+    let num = '', name = '', longName = '';
     let transitNames = '';
     let offscreenNames = '';
     let eclipsedNames = '';
@@ -252,9 +252,9 @@ export class SvcMoonsViewComponent extends GenericPlanetaryView implements After
     for (let i = 0; i <= moons.length; ++i) {
       if (i < moons.length) {
         pos = moons[i];
-        number = PlanetaryMoons.getMoonNumber(pos.moonIndex);
+        num = PlanetaryMoons.getMoonNumber(pos.moonIndex);
         name = PlanetaryMoons.getMoonName(pos.moonIndex);
-        longName = name + ' (' + number + ')';
+        longName = name + ' (' + num + ')';
         drawMoon = true;
         hidden = false;
 
@@ -372,7 +372,7 @@ export class SvcMoonsViewComponent extends GenericPlanetaryView implements After
             if (this.moonNumbers && this.moonNames)
               name = longName;
             else if (this.moonNumbers)
-              name = number;
+              name = num;
 
             const li = {name: name, pt: pt, labelType: hidden ? LABEL_TYPE.HIDDEN_MOON : LABEL_TYPE.MOON, bodyIndex: pos.moonIndex};
             this.addLabel(li, dc);
diff --git a/src/app/svc/svc-orbit-view/svc-orbit-view.component.ts b/src/app/svc/svc-orbit-view/svc-orbit-view.component.ts
@@ -85,7 +85,7 @@ enum DrawingMode { FULL_COLOR, LEFT_EYE, RIGHT_EYE }
 const orbitColors: string[][] = [];
 const SHADES = 50;
 
-(function(): void {
+((): void => {
   for (let i = 0; i < planetColors.length + 4; ++i) {
     const shades = [];
     let rgb: RGBA;
@@ -265,9 +265,7 @@ export class SvcOrbitViewComponent extends GenericPlanetaryView implements After
       const orbitStep = 1.0;
       this.zBuffer.clear();
 
-      for (let i = 0; i < this.planetsToDraw.length; ++i) {
-        const planet = this.planetsToDraw[i];
-
+      for (const planet of this.planetsToDraw) {
         // Don't draw an orbit for the Sun.
         if (planet === SUN)
           continue;
@@ -448,9 +446,7 @@ export class SvcOrbitViewComponent extends GenericPlanetaryView implements After
 
     let positions: ZSortablePlanet[] = [];
 
-    for (let i = 0; i < this.planetsToDraw.length; ++i) {
-      const planet = this.planetsToDraw[i];
-
+    for (const planet of this.planetsToDraw) {
       pt0 = dc.ss.getHeliocentricPosition(planet, dc.jde).xyz;
       SvcOrbitViewComponent.translate(mode, pt0, ctr, viewingDistance, cos_xz, sin_xz, cos_yz, sin_yz);
 
diff --git a/src/app/svc/svc-preferences-dialog/svc-preferences-dialog.component.ts b/src/app/svc/svc-preferences-dialog/svc-preferences-dialog.component.ts
@@ -108,7 +108,6 @@ export class SvcPreferencesDialogComponent {
   };
 
   @Input() get visible(): boolean { return this._visible; }
-  @Output() visibleChange: EventEmitter<any> = new EventEmitter();
   set visible(isVisible: boolean) {
     if (this._visible !== isVisible) {
       this._visible = isVisible;
@@ -144,6 +143,7 @@ export class SvcPreferencesDialogComponent {
       }
     }
   }
+  @Output() visibleChange: EventEmitter<any> = new EventEmitter();
 
   get twilightByDegrees(): boolean { return this._twilightByDegrees; }
   set twilightByDegrees(value) {
diff --git a/src/app/svc/svc-zone-selector/svc-zone-selector.component.html b/src/app/svc/svc-zone-selector/svc-zone-selector.component.html
@@ -1,14 +1,14 @@
 <div class="zone-selector">
   <div class="zone-selector-row">
-    <ks-dropdown [options]="regions"  [(ngModel)]="region"  [disabled]="disabled" (onFocus)="onDropdownFocus($event)"
-                 (onBlur)="onDropdownBlur($event)" scrollHeight="420px"></ks-dropdown><br>
+    <ks-dropdown [options]="regions"  [(ngModel)]="region"  [disabled]="disabled" (focus)="onDropdownFocus($event)"
+                 (blur)="onDropdownBlur($event)" scrollHeight="420px"></ks-dropdown><br>
   </div>
   <div class="zone-selector-row">
     <span class="caption">time zone region/category &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</span><br>
   </div>
   <div class="zone-selector-row">
-    <ks-dropdown [options]="subzones" [(ngModel)]="subzone" [disabled]="disabled" (onFocus)="onDropdownFocus($event)"
-                 (onBlur)="onDropdownBlur($event)" scrollHeight="300px"></ks-dropdown><br>
+    <ks-dropdown [options]="subzones" [(ngModel)]="subzone" [disabled]="disabled" (focus)="onDropdownFocus($event)"
+                 (blur)="onDropdownBlur($event)" scrollHeight="300px"></ks-dropdown><br>
   </div>
   <div class="zone-selector-row">
     <span class="caption">specific time zone &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</span>
diff --git a/src/app/svc/svc-zone-selector/svc-zone-selector.component.ts b/src/app/svc/svc-zone-selector/svc-zone-selector.component.ts
@@ -67,8 +67,8 @@ export class SvcZoneSelectorComponent implements ControlValueAccessor, OnInit {
   disabled = false;
   error: string;
 
-  @Output() onFocus: EventEmitter<any> = new EventEmitter();
-  @Output() onBlur: EventEmitter<any> = new EventEmitter();
+  @Output() focus: EventEmitter<any> = new EventEmitter();
+  @Output() blur: EventEmitter<any> = new EventEmitter();
 
   constructor(private appService: AppService) {
     this.lastSubzones[this._region] = this._subzone;
@@ -154,7 +154,7 @@ export class SvcZoneSelectorComponent implements ControlValueAccessor, OnInit {
     this.hasFocus = true;
 
     if (this.focusCount++ === 0) {
-      this.onFocus.emit(event);
+      this.focus.emit(event);
     }
   }
 
@@ -167,7 +167,7 @@ export class SvcZoneSelectorComponent implements ControlValueAccessor, OnInit {
 
       if (!this.hasFocus) {
         this.onTouchedCallback();
-        this.onBlur.emit(event);
+        this.blur.emit(event);
       }
     });
   }
diff --git a/src/app/widgets/ks-checkbox/ks-checkbox.component.html b/src/app/widgets/ks-checkbox/ks-checkbox.component.html
@@ -1,3 +1,3 @@
 <p-checkbox #checkbox [(ngModel)]="ngValue" [disabled]="disabled" [value]="value"
   (onFocus)="onDropdownFocus($event)" (onBlur)="onDropdownBlur($event)" [binary]="binary"></p-checkbox>
-<span (click)="onClick($event)" [ngClass]="{'faded': disabled}">{{label}}</span>
+<span (click)="onClick($event)" [ngClass]="{'faded': disabled}">{{label}}</span>
diff --git a/src/app/widgets/ks-checkbox/ks-checkbox.component.ts b/src/app/widgets/ks-checkbox/ks-checkbox.component.ts
@@ -45,8 +45,8 @@ export class KsCheckboxComponent implements ControlValueAccessor {
 
   @ViewChild('checkbox', { static: true }) private checkboxRef: ElementRef;
 
-  @Output() onFocus: EventEmitter<any> = new EventEmitter();
-  @Output() onBlur: EventEmitter<any> = new EventEmitter();
+  @Output() focus: EventEmitter<any> = new EventEmitter();
+  @Output() blur: EventEmitter<any> = new EventEmitter();
   @Input() label: string;
   @Input() binary: boolean;
   @Input() value: any;
@@ -61,13 +61,13 @@ export class KsCheckboxComponent implements ControlValueAccessor {
 
   onDropdownFocus(event: any): void {
     this.hasFocus = true;
-    this.onFocus.emit(event);
+    this.focus.emit(event);
   }
 
   onDropdownBlur(event: any): void {
     this.hasFocus = false;
     this.onTouchedCallback();
-    this.onBlur.emit(event);
+    this.blur.emit(event);
   }
 
   writeValue(newValue: any): void {
diff --git a/src/app/widgets/ks-dropdown/ks-dropdown.component.ts b/src/app/widgets/ks-dropdown/ks-dropdown.component.ts
@@ -54,8 +54,8 @@ export class KsDropdownComponent implements ControlValueAccessor, OnInit {
   disabled = false;
   useSelect = true;
 
-  @Output() onFocus: EventEmitter<any> = new EventEmitter();
-  @Output() onBlur: EventEmitter<any> = new EventEmitter();
+  @Output() focus: EventEmitter<any> = new EventEmitter();
+  @Output() blur: EventEmitter<any> = new EventEmitter();
   @Input() autoWidth = false; // TODO: Add my own support for autoWidth, now that PrimeNG doesn't support it?
   @Input() editable = false;
   @Input() scrollHeight = '200px';
@@ -91,13 +91,13 @@ export class KsDropdownComponent implements ControlValueAccessor, OnInit {
 
   onDropdownFocus(event: any): void {
     this.hasFocus = true;
-    this.onFocus.emit(event);
+    this.focus.emit(event);
   }
 
   onDropdownBlur(event: any): void {
     this.hasFocus = false;
     this.onTouchedCallback();
-    this.onBlur.emit(event);
+    this.blur.emit(event);
   }
 
   writeValue(newValue: any): void {
diff --git a/src/app/widgets/ks-marquee/ks-marquee.component.ts b/src/app/widgets/ks-marquee/ks-marquee.component.ts
@@ -1,5 +1,5 @@
 /*
-  Copyright © 2018 Kerry Shetline, kerry@shetline.com
+  Copyright © 2018-2019 Kerry Shetline, kerry@shetline.com
 
   MIT license: https://opensource.org/licenses/MIT
 
@@ -32,7 +32,7 @@ const MARQUEE_SPEED = 100; // pixels per second.
 })
 export class KsMarqueeComponent implements AfterViewInit, OnDestroy {
   private _text = '';
-  private resizeFunction: Function;
+  private resizeFunction: () => void;
   private wrapper: HTMLElement;
   private marquee: HTMLElement;
   private animationRequestId = 0;
diff --git a/src/app/widgets/ks-sequence-editor/ks-sequence-editor.component.ts b/src/app/widgets/ks-sequence-editor/ks-sequence-editor.component.ts
@@ -230,8 +230,8 @@ export class KsSequenceEditorComponent implements AfterViewInit, OnInit, OnDestr
       this.hiddenInput.setAttribute('autocorrect', 'off');
       this.hiddenInput.style.position = 'absolute';
       this.hiddenInput.style.opacity = '0';
-      this.hiddenInput.style['caret-color'] = 'transparent';
-      this.hiddenInput.style['pointer-events'] = 'none';
+      (this.hiddenInput.style as any)['caret-color'] = 'transparent';
+      (this.hiddenInput.style as any)['pointer-events'] = 'none';
       this.hiddenInput.style.left = '0';
       this.hiddenInput.style.top = '-6px';
 
diff --git a/src/app/widgets/ks-tab-view/ks-tab-view.component.ts b/src/app/widgets/ks-tab-view/ks-tab-view.component.ts
@@ -1,5 +1,5 @@
 /*
-  Copyright © 2017 Kerry Shetline, kerry@shetline.com
+  Copyright © 2017-2019 Kerry Shetline, kerry@shetline.com
 
   MIT license: https://opensource.org/licenses/MIT
 
@@ -28,7 +28,7 @@ import { KsTabComponent } from '../ks-tab/ks-tab.component';
 export class KsTabViewComponent implements AfterContentInit {
   private _activeTab = -1;
 
-  @Output() onChange = new EventEmitter();
+  @Output() change = new EventEmitter();
 
   @ContentChildren(KsTabComponent) tabs: QueryList<KsTabComponent>;
 
@@ -38,7 +38,7 @@ export class KsTabViewComponent implements AfterContentInit {
       this._activeTab = value;
       this.tabs.toArray().forEach((tab: KsTabComponent, index: number) => tab.active = (index === value));
 
-      this.onChange.emit(value);
+      this.change.emit(value);
     }
   }
 
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -1 +1,2 @@
 declare module 'googlemaps';
+declare module 'detect-resize';
diff --git a/tsconfig.json b/tsconfig.json
@@ -8,6 +8,7 @@
     "moduleResolution": "node",
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
+    "noImplicitAny": true,
     "target": "es2015",
     "typeRoots": [
       "node_modules/@types"
diff --git a/tslint.json b/tslint.json
