Skip to content

Commit c1750c0

Browse files
committed
Fixed ecliptic and celestial grid lines sometimes being too faint. Improved consistency of font for astronomical symbols.
1 parent 7355f00 commit c1750c0

12 files changed

Lines changed: 33 additions & 16 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "svc-ng",
3-
"version": "1.4.8",
3+
"version": "1.4.9",
44
"license": "MIT AND GPL-3.0-or-later",
55
"author": "Kerry Shetline <kerry@shetline.com>",
66
"scripts": {

src/app/app.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="about-dialog">
33
<img src="/assets/resources/svc_lunar_eclipse.png" alt="lunar eclipse" width="64" height="64">
44
<h2>Sky View Café NP</h2>
5-
Version 1.4.8<br><br>
5+
Version 1.4.9<br><br>
66
Copyright © 2016-2018 Kerry Shetline.
77
</div>
88
</p-dialog>

src/app/svc/svc-calendar-view/svc-calendar-view.component.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ div.edge-ie-fix-1 {
101101

102102
span.planet-glyph {
103103
vertical-align: middle;
104-
font-size: 1.2em;
104+
font-family: Astronomy, Arial, Helvetica, sans-serif;
105+
font-size: 1.5em;
105106
color: #00FF99;
106107
}
107108

@@ -127,13 +128,18 @@ div.phase {
127128
}
128129

129130
div.daylight {
131+
font-family: Astronomy, Arial, Helvetica, sans-serif;
130132
font-size: 0.833em;
131133
color: #FFFF99;
132134
text-shadow: -1px -1px black, -1px 1px black, 1px -1px black, 1px 1px black;
133135
position: absolute;
134-
bottom: 0;
136+
bottom: -1px;
135137
right: 2px;
136138
text-align: right;
139+
140+
&::first-letter {
141+
font-size: 1.5em;
142+
}
137143
}
138144

139145
div.edge-ie-fix-2 {

src/app/svc/svc-calendar-view/svc-calendar-view.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export class SvcCalendarViewComponent implements AfterViewInit {
389389
const mins = daylight % 60;
390390
const hours = (daylight - mins) / 60;
391391

392-
date.daylight = '\u2600' + hours + 'h' + (mins < 10 ? '0' : '') + mins + 'm';
392+
date.daylight = '\u263C' + hours + 'h' + (mins < 10 ? '0' : '') + mins + 'm';
393393
}
394394
else
395395
date.daylight = '';

src/app/svc/svc-sky-view/svc-sky-view.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1043,9 +1043,9 @@ export class SvcSkyViewComponent extends GenericSkyView implements AfterViewInit
10431043

10441044
if (dc.minStarBrightness > 0) {
10451045
if (this.skyColor === SKY_COLOR.BASIC)
1046-
gridColor = replaceAlpha(gridColor, 0.4 + 0.15 * dc.minStarBrightness);
1046+
gridColor = replaceAlpha(gridColor, 0.4 + 0.0015 * dc.minStarBrightness);
10471047
else
1048-
gridColor = replaceAlpha(gridColor, 0.4 - 0.15 * dc.minStarBrightness);
1048+
gridColor = replaceAlpha(gridColor, 0.4 - 0.0015 * dc.minStarBrightness);
10491049
}
10501050

10511051
// Draw celestial equator and lines of celestial latitude
@@ -1138,9 +1138,9 @@ export class SvcSkyViewComponent extends GenericSkyView implements AfterViewInit
11381138

11391139
if (dc.minStarBrightness > 0) {
11401140
if (this.skyColor === SKY_COLOR.BASIC)
1141-
gridColor = replaceAlpha(gridColor, 0.4 + 0.15 * dc.minStarBrightness);
1141+
gridColor = replaceAlpha(gridColor, 0.4 + 0.0015 * dc.minStarBrightness);
11421142
else
1143-
gridColor = replaceAlpha(gridColor, 0.4 - 0.15 * dc.minStarBrightness);
1143+
gridColor = replaceAlpha(gridColor, 0.4 - 0.0015 * dc.minStarBrightness);
11441144
}
11451145

11461146
// Draw ecliptic and lines of ecliptic latitude
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div #wrapper class="wrapper"><div class="spacer"></div><div #marquee class="marquee">{{text}}</div></div>
1+
<div #wrapper class="wrapper"><div class="spacer">&nbsp;</div><div #marquee class="marquee">{{text}}</div></div>

src/app/widgets/ks-marquee/ks-marquee.component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,10 @@ export class KsMarqueeComponent implements AfterViewInit, OnDestroy {
6868
}
6969

7070
onResize(): void {
71-
if (this.animationRequestId)
71+
if (this.animationRequestId) {
7272
window.cancelAnimationFrame(this.animationRequestId);
73+
this.animationRequestId = 0;
74+
}
7375

7476
if (!this.wrapper || !this.marquee)
7577
return;
@@ -97,9 +99,9 @@ export class KsMarqueeComponent implements AfterViewInit, OnDestroy {
9799
this.marquee.scrollLeft = 0;
98100
}
99101
else if (now > this.animationStart + HOLD_TIME) {
100-
const timeIntoSlide = now - this.animationStart - HOLD_TIME;
102+
const timeIntoScroll = now - this.animationStart - HOLD_TIME;
101103

102-
this.marquee.scrollLeft = min(this.animationWidth, timeIntoSlide / 1000 * MARQUEE_SPEED);
104+
this.marquee.scrollLeft = min(this.animationWidth, timeIntoScroll / 1000 * MARQUEE_SPEED);
103105
}
104106

105107
this.animationRequestId = window.requestAnimationFrame(() => this.animate());

src/app/widgets/ks-sequence-editor/ks-sequence-editor.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ export class KsSequenceEditorComponent implements AfterViewInit, OnInit, OnDestr
614614
return false;
615615
}
616616

617-
// In at least one version of Android many key events carry no useful information about the key that was
617+
// With Android many on-screen keyboard key events carry no useful information about the key that was
618618
// pressed. They instead match the following test and we have to grab a character out of the hidden
619619
// input field to find out what was actually typed in.
620620
if (this.hiddenInput && key === 'Unidentified' && event.keyCode === 229) {
@@ -628,7 +628,7 @@ export class KsSequenceEditorComponent implements AfterViewInit, OnInit, OnDestr
628628
return true;
629629

630630
// If the built-in auto-repeat is in effect, ignore keystrokes that come along until that auto-repeat ends.
631-
if (!this.keyTimer) {
631+
if (!this.keyTimer && key !== 'Shift') {
632632
this.onKey(key);
633633
this.keyTimer = timer(KEY_REPEAT_DELAY, KEY_REPEAT_RATE).subscribe(() => this.onKey(key));
634634
}

src/assets/about.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@
6060
<h2 class="header-sans"><a name="history">What's New / Version History</a></h2>
6161
<div style="padding-left: 1em; text-indent: -1em">
6262

63+
<p><b>1.4.9, 2018-08-04:</b> Fixed ecliptic and celestial grid lines sometimes being too faint. Improved consistency
64+
of font for astronomical symbols.</p>
65+
6366
<p><b>1.4.8, 2018-07-30:</b> Fixed problems with one keyboard's too-rapid autorepeat.</p>
6467

6568
<p><b>1.4.7, 2018-07-30:</b> Made pointing with a tablet pen work. Cleaned up console errors.</p>

0 commit comments

Comments
 (0)