Exposing the TracePoint object seems overly dependent on the impl

Author: hibariya

lib/orthoses/trace/attribute.rb

@@ -64,7 +64,7 @@ def build_trace_hook
             mod_name = m[1]
           end
           next unless mod_name
-          next unless target?(mod_name, tp1)
+          next unless target?(mod_name)
           is_singleton = tp1.self.singleton_class?
           prefix = is_singleton ? "self." : ""
           kind = tp1.method_id

lib/orthoses/trace/attribute_test.rb

@@ -121,7 +121,7 @@ class TraceAttributeTest::Foo::Baz
   end
 
   def test_pattern_proc(t)
-    patterns = ->(name, tp) { tp.self.name == "TraceAttributeTest::Foo" }
+    patterns = ->(name) { name == "TraceAttributeTest::Foo" }
     store = Orthoses::Trace::Attribute.new(->{
       LOADER_ATTRIBUTE.call
       foo = Foo.new

lib/orthoses/trace/method.rb

@@ -44,7 +44,7 @@ def build_trace_point
             kind = :instance
           end
 
-          next unless target?(mod_name, tp)
+          next unless target?(mod_name)
 
           case tp.event
           when :call

lib/orthoses/trace/method_test.rb

@@ -142,7 +142,7 @@ def self.a: () -> Integer
 
   def test_pattern_proc(t)
     # only non-private methods
-    patterns = ->(name, tp) { name == "TraceMethodTest::M" && !tp.self.private_methods.include?(tp.method_id) }
+    patterns = ->(name) { name == "TraceMethodTest::M" }
     store = Orthoses::Trace::Method.new(-> {
       LOADER_METHOD.call
 
@@ -156,7 +156,9 @@ def test_pattern_proc(t)
     actual = store.map { |n, c| c.to_rbs }.join("\n")
     expect = <<~RBS
       class TraceMethodTest::M
+        private def initialize: (Integer a) -> void
         def a_ten: () -> Integer
+        private def priv: (bool bool) -> Integer
         def call_priv: (bool c) -> Integer
       end
     RBS

lib/orthoses/trace/targetable.rb

@@ -3,9 +3,9 @@
 module Orthoses
   class Trace
     module Targetable
-      def target?(name, tp)
+      def target?(name)
         if @patterns.respond_to?(:call)
-          @patterns.call(name, tp)
+          @patterns.call(name)
         else
           @patterns.any? do |pattern|
             if pattern.end_with?("*")