Skip to content

Commit 88ca1c8

Browse files
committed
Rename WorkflowCommonParameters parameter
This naming doesn't make sense if the non-workflow parameter equivalent is called CommonOptions. My suggestion is to change the name so it is obvious which structures belong together.
1 parent 19ed9f0 commit 88ca1c8

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

api/v1beta1/ansibletest_types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ type AnsibleTestSpec struct {
9999
}
100100

101101
type AnsibleTestWorkflowSpec struct {
102-
WorkflowCommonParameters `json:",inline"`
103-
CommonOpenstackConfig `json:",inline"`
102+
WorkflowCommonOptions `json:",inline"`
103+
CommonOpenstackConfig `json:",inline"`
104104

105105
// +operator-sdk:csv:customresourcedefinitions:type=spec
106106
// +kubebuilder:validation:Required

api/v1beta1/common.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ type CommonTestStatus struct {
133133
NetworkAttachments map[string][]string `json:"networkAttachments,omitempty"`
134134
}
135135

136-
type WorkflowCommonParameters struct {
136+
type WorkflowCommonOptions struct {
137137
// +operator-sdk:csv:customresourcedefinitions:type=spec
138138
// +kubebuilder:validation:optional
139139
// +optional

api/v1beta1/tempest_types_workflow.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,8 @@ type WorkflowTempestconfRunSpec struct {
227227
// TempestSpec - configuration of execution of tempest. For specific configuration
228228
// of tempest see TempestRunSpec and for discover-tempest-config see TempestconfRunSpec.
229229
type WorkflowTempestSpec struct {
230-
WorkflowCommonParameters `json:",inline"`
231-
CommonOpenstackConfig `json:",inline"`
230+
WorkflowCommonOptions `json:",inline"`
231+
CommonOpenstackConfig `json:",inline"`
232232

233233
// The desired amount of resources that should be assigned to each test pod
234234
// spawned using the Tempest CR. https://pkg.go.dev/k8s.io/api/core/v1#ResourceRequirements

api/v1beta1/tobiko_types.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ type TobikoSpec struct {
119119
}
120120

121121
type TobikoWorkflowSpec struct {
122-
WorkflowCommonParameters `json:",inline"`
122+
WorkflowCommonOptions `json:",inline"`
123123

124124
// +kubebuilder:default:={limits: {cpu: "8000m", memory: "8Gi"}, requests: {cpu: "4000m", memory: "4Gi"}}
125125
// The desired amount of resources that should be assigned to each test pod

api/v1beta1/zz_generated.deepcopy.go

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)