Bump rubocop + use rubocop-basic

Author: ksylvest

.rubocop.yml

@@ -1,19 +1,13 @@
-require:
+inherit_gem:
+  rubocop-basic: rubocop.yml
+
+plugins:
   - rubocop-factory_bot
   - rubocop-rake
   - rubocop-rails
   - rubocop-rspec
   - rubocop-rspec_rails
 
-AllCops:
-  NewCops: enable
-  TargetRubyVersion: 2.6
-
-Gemspec/RequireMFA:
-  Enabled: false
-
-Gemspec/DevelopmentDependencies:
-  Enabled: false
-
 RSpec/SpecFilePathFormat:
-  Enabled: false
+  CustomTransform:
+    GraphQL: graphql

Gemfile

@@ -1,10 +1,21 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
-gem 'rake'
-gem 'rspec'
-gem 'rubocop'
-gem 'yard'
+gem "factory_bot"
+gem "pg"
+gem "rake"
+gem "rspec"
+gem "rspec_junit_formatter"
+gem "rspec-rails"
+gem "rubocop"
+gem "rubocop-basic"
+gem "rubocop-factory_bot"
+gem "rubocop-rails"
+gem "rubocop-rake"
+gem "rubocop-rspec"
+gem "rubocop-rspec_rails"
+gem "simplecov"
+gem "yard"

Gemfile.lock

@@ -246,6 +246,7 @@ GEM
     rubocop-ast (1.45.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
+    rubocop-basic (1.2.0)
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -309,6 +310,7 @@ DEPENDENCIES
   rspec-rails
   rspec_junit_formatter
   rubocop
+  rubocop-basic
   rubocop-factory_bot
   rubocop-rails
   rubocop-rake

Rakefile

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-require 'rubocop/rake_task'
+require "rubocop/rake_task"
 
 RuboCop::RakeTask.new
 

graphql-sources.gemspec

@@ -1,40 +1,31 @@
 # frozen_string_literal: true
 
-require_relative 'lib/graphql/sources/version'
+require_relative "lib/graphql/sources/version"
 
 Gem::Specification.new do |spec|
-  spec.name = 'graphql-sources'
+  spec.name = "graphql-sources"
   spec.version = GraphQL::Sources::VERSION
-  spec.authors = ['Kevin Sylvestre']
-  spec.email = ['kevin@ksylvest.com']
-
-  spec.summary = 'A set of common GraphQL DataLoader sources.'
-  spec.description = 'Common loaders for various database or cache operations.'
-  spec.homepage = 'https://github.com/ksylvest/graphql-sources'
-  spec.license = 'MIT'
-  spec.required_ruby_version = '>= 2.6.0'
-
-  spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = "https://github.com/ksylvest/graphql-sources/tree/v#{GraphQL::Sources::VERSION}"
-  spec.metadata['changelog_uri'] = "https://github.com/ksylvest/graphql-sources/releases/tag/v#{GraphQL::Sources::VERSION}"
-  spec.metadata['documentation_uri'] = 'https://graphql-sources.ksylvest.com/'
-
-  spec.files = Dir.glob('{bin,lib}/**/*') + %w[README.md LICENSE Gemfile]
-
-  spec.require_paths = ['lib']
-
-  spec.add_dependency 'graphql'
-  spec.add_dependency 'rails'
-  spec.add_dependency 'zeitwerk'
-  spec.add_development_dependency 'factory_bot'
-  spec.add_development_dependency 'pg'
-  spec.add_development_dependency 'rspec_junit_formatter'
-  spec.add_development_dependency 'rspec-rails'
-  spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'rubocop-factory_bot'
-  spec.add_development_dependency 'rubocop-rails'
-  spec.add_development_dependency 'rubocop-rake'
-  spec.add_development_dependency 'rubocop-rspec'
-  spec.add_development_dependency 'rubocop-rspec_rails'
-  spec.add_development_dependency 'simplecov'
+  spec.authors = ["Kevin Sylvestre"]
+  spec.email = ["kevin@ksylvest.com"]
+
+  spec.summary = "A set of common GraphQL DataLoader sources."
+  spec.description = "Common loaders for various database or cache operations."
+  spec.homepage = "https://github.com/ksylvest/graphql-sources"
+  spec.license = "MIT"
+  spec.required_ruby_version = ">= 2.6.0"
+
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/ksylvest/graphql-sources/tree/v#{GraphQL::Sources::VERSION}"
+  spec.metadata["changelog_uri"] = "https://github.com/ksylvest/graphql-sources/releases/tag/v#{GraphQL::Sources::VERSION}"
+  spec.metadata["documentation_uri"] = "https://graphql-sources.ksylvest.com/"
+
+  spec.metadata["rubygems_mfa_required"] = "true"
+
+  spec.files = Dir.glob("{bin,lib}/**/*") + %w[README.md LICENSE Gemfile]
+
+  spec.require_paths = ["lib"]
+
+  spec.add_dependency "graphql"
+  spec.add_dependency "rails"
+  spec.add_dependency "zeitwerk"
 end

lib/graphql/sources.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'graphql'
-require 'zeitwerk'
+require "graphql"
+require "zeitwerk"
 
 loader = Zeitwerk::Loader.for_gem
 loader.push_dir(__dir__, namespace: GraphQL)

lib/graphql/sources/active_record_base.rb

@@ -21,7 +21,7 @@ def initialize(model, key: :id)
         @key = key
       end
 
-      protected
+    protected
 
       # @param keys [Array] an array of keys
       # @return [ActiveRecord_Relation] a collection of records

lib/graphql/sources/active_storage_base.rb

@@ -10,7 +10,7 @@ def initialize(name)
         @name = name
       end
 
-      protected
+    protected
 
       # @param records [Array<ActiveRecord::Base>] a collection of records to load attachments for
       # @return [Array<ActiveStorage::Attachment>] the associated attachments with preloaded blobs

lib/graphql/sources/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module Sources
-    VERSION = '1.5.4'
+    VERSION = "1.5.4"
   end
 end

spec/dummy/Rakefile

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-require_relative 'config/application'
+require_relative "config/application"
 
 Rails.application.load_tasks