fix(image): match legacy Android accessibility handling

Author: mfkrause

packages/react-native-boost/src/plugin/__tests__/parity/parity.test.ts

@@ -129,6 +129,8 @@ const IMAGE_CASES = [
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} tintColor={null} style={{ tintColor: "red" }} />',
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} crossOrigin="use-credentials" referrerPolicy="origin" />',
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} alt="Logo" />',
+  '<Image source={{ uri: "logo.png", width: 16, height: 16 }} alt={null} aria-label="Logo" />',
+  '<Image source={{ uri: "logo.png", width: 16, height: 16 }} accessible={null} />',
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} aria-label="Logo" accessibilityLabel="Fallback" />',
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} aria-hidden={true} accessible={true} />',
   '<Image source={{ uri: "logo.png", width: 16, height: 16 }} aria-busy={true} accessibilityState={{ selected: true }} />',

packages/react-native-boost/src/runtime/__tests__/index.test.ts

@@ -472,6 +472,26 @@ describe('processImageAccessibilityProps', () => {
     expect(processImageAccessibilityProps({ alt: undefined, accessible: false }).accessible).toBe(false);
   });
 
+  describe('Android null handling follows the installed RN version', () => {
+    afterEach(restorePlatformMock);
+
+    it.each([
+      [84, { accessibilityLabel: 'Label', accessible: true }],
+      [85, { accessibilityLabel: 'Label' }],
+    ])('handles a null alt on RN 0.%i', async (minor, expected) => {
+      const runtime = await loadRuntime(minor);
+      expect(runtime.processImageAccessibilityProps({ 'alt': null, 'aria-label': 'Label' })).toEqual(expected);
+    });
+
+    it.each([
+      [84, { accessible: null }],
+      [85, {}],
+    ])('handles a null accessible prop on RN 0.%i', async (minor, expected) => {
+      const runtime = await loadRuntime(minor);
+      expect(runtime.processImageAccessibilityProps({ accessible: null })).toEqual(expected);
+    });
+  });
+
   it('uses aria-hidden to force accessible off on iOS while preserving importantForAccessibility', () => {
     Platform.OS = 'ios';
     expect(

packages/react-native-boost/src/runtime/index.ts

@@ -544,10 +544,7 @@ export function processImageAccessibilityProps(props: Record<string, any>): Reco
     result.accessibilityLabelledBy = accessibilityLabelledBy;
   }
 
-  // The two wrappers resolve `accessible` with DIFFERENT nullish semantics: iOS computes
-  // `ariaHidden !== true && (alt !== undefined ? true : accessible)`, while Android (RN >= 0.85)
-  // skips a nullish `alt`/`accessible` entirely (`!= null`), so an `alt={null}` forces `accessible`
-  // on iOS only.
+  // RN 0.85 changed Android from undefined checks to nullish checks.
   if (Platform.OS === 'ios') {
     if (ariaHidden === true) {
       result.accessible = false;
@@ -556,10 +553,14 @@ export function processImageAccessibilityProps(props: Record<string, any>): Reco
     } else if (accessible !== undefined) {
       result.accessible = accessible;
     }
-  } else if (alt != null) {
-    result.accessible = true;
-  } else if (accessible != null) {
-    result.accessible = accessible;
+  } else {
+    const minor = getReactNativeMinor();
+    const usesUndefinedChecks = minor !== null && minor <= 84;
+    if (usesUndefinedChecks ? alt !== undefined : alt != null) {
+      result.accessible = true;
+    } else if (usesUndefinedChecks ? accessible !== undefined : accessible != null) {
+      result.accessible = accessible;
+    }
   }
 
   if (ariaHidden === true && Platform.OS !== 'ios') {