Avoid replacing navigator.serial object

kuba2k2 · kuba2k2 · commit 6f425cb4174e · 2025-05-29T17:55:57.000+02:00
diff --git a/src/polyfill.ts b/src/polyfill.ts
@@ -290,5 +290,8 @@ class Serial extends EventTarget {
 	}
 }
 
-// @ts-ignore
-navigator.serial = new Serial()
+// copy functions instead of creating a new object,
+// so that references to navigator.serial are always valid
+const serial = new Serial()
+navigator.serial.getPorts = serial.getPorts.bind(serial)
+navigator.serial.requestPort = serial.requestPort.bind(serial)

Original file line number	Diff line number	Diff line change
`@@ -290,5 +290,8 @@ class Serial extends EventTarget {`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`
`293`		`-// @ts-ignore`
`294`		`-navigator.serial = new Serial()`
	`293`	`+// copy functions instead of creating a new object,`
	`294`	`+// so that references to navigator.serial are always valid`
	`295`	`+const serial = new Serial()`
	`296`	`+navigator.serial.getPorts = serial.getPorts.bind(serial)`
	`297`	`+navigator.serial.requestPort = serial.requestPort.bind(serial)`