chore: enable the modernize analyzer and apply it

golangci-lint gains the modernize analyzer, and the tree is updated to satisfy
it. The changes are mechanical: range-over-int loops, slices and maps helpers in
place of hand-written loops, min and max builtins, and new(x) in place of a
local variable taken by address.

persistentVolumeModePointer went with them. It wrapped new(mode) for a single
caller, which the inline analyzer flags.

Signed-off-by: Bence Csati <bence.csati@axoflow.com>

Author: csatib02

.golangci.yml

@@ -36,6 +36,7 @@ linters:
     - errcheck
     - ineffassign
     - misspell
+    - modernize
     - nolintlint
     - revive
     - gocyclo

e2e/common/setup/loggingoperator.go

@@ -87,7 +87,7 @@ func LoggingOperator(t *testing.T, c common.Cluster, opts ...LoggingOperatorOpti
 	}
 	actionConfig := new(action.Configuration)
 
-	if err := actionConfig.Init(restClientGetter, opt.Namespace, "memory", func(format string, v ...interface{}) {
+	if err := actionConfig.Init(restClientGetter, opt.Namespace, "memory", func(format string, v ...any) {
 		t.Logf(format, v...)
 	}); err != nil {
 		t.Fatalf("helm action config init: %s", err)
@@ -129,29 +129,29 @@ func LoggingOperator(t *testing.T, c common.Cluster, opts ...LoggingOperatorOpti
 		t.Fatalf("kind load images: %s", err)
 	}
 
-	_, err = installer.Run(chartReq, map[string]interface{}{
+	_, err = installer.Run(chartReq, map[string]any{
 		"nameOverride": opt.NameOverride,
-		"image": map[string]interface{}{
+		"image": map[string]any{
 			"repository": loggingOperatorImage.repository,
 			"tag":        loggingOperatorImage.tag,
 			"pullPolicy": corev1.PullNever,
 		},
-		"testReceiver": map[string]interface{}{
+		"testReceiver": map[string]any{
 			"enabled": true,
 		},
-		"volumes": []map[string]interface{}{
+		"volumes": []map[string]any{
 			{
 				"name":     "coverage-data",
 				"emptyDir": map[string]string{},
 			},
 		},
-		"volumeMounts": []map[string]interface{}{
+		"volumeMounts": []map[string]any{
 			{
 				"mountPath": "/covdatafiles",
 				"name":      "coverage-data",
 			},
 		},
-		"env": []map[string]interface{}{
+		"env": []map[string]any{
 			{
 				"name":  "GOCOVERDIR",
 				"value": "/covdatafiles",

e2e/fluentd-aggregator/fluentd_aggregator_test.go

@@ -21,6 +21,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"regexp"
+	"slices"
 	"strings"
 	"testing"
 	"time"
@@ -412,11 +413,9 @@ func TestFluentdAggregator_ConfigChecks(t *testing.T) {
 				return false
 			}
 			if logging.Status.ProblemsCount > 0 {
-				for _, problem := range logging.Status.Problems {
-					if configCheckFailure.MatchString(problem) {
-						t.Logf("Found the problem in Logging status: %v", logging.Status)
-						return true
-					}
+				if slices.ContainsFunc(logging.Status.Problems, configCheckFailure.MatchString) {
+					t.Logf("Found the problem in Logging status: %v", logging.Status)
+					return true
 				}
 			}
 			t.Logf("Waiting for the problem to appear in Logging status: %v", logging.Status.Problems)
@@ -433,11 +432,9 @@ func TestFluentdAggregator_ConfigChecks(t *testing.T) {
 				return false
 			}
 			if logging.Status.ProblemsCount > 0 {
-				for _, problem := range logging.Status.Problems {
-					if configCheckFailure.MatchString(problem) {
-						t.Logf("Waiting for the problem to be cleared in Logging status: %v", logging.Status.Problems)
-						return false
-					}
+				if slices.ContainsFunc(logging.Status.Problems, configCheckFailure.MatchString) {
+					t.Logf("Waiting for the problem to be cleared in Logging status: %v", logging.Status.Problems)
+					return false
 				}
 			}
 			t.Logf("Problem cleared in Logging status: %v", logging.Status)

pkg/sdk/extensions/api/v1alpha1/eventtailer_types.go

@@ -27,12 +27,12 @@ import (
 
 // +name:"EventTailer"
 // +weight:"200"
-type _hugoEventTailer = interface{} //nolint:deadcode,unused
+type _hugoEventTailer = any //nolint:deadcode,unused
 
 // +name:"EventTailer"
 // +version:"v1alpha1"
 // +description:"Eventtailer's main goal is to listen kubernetes events and transmit their changes to stdout. This way the logging-operator is able to process them."
-type _metaEventTailer = interface{} //nolint:deadcode,unused
+type _metaEventTailer = any //nolint:deadcode,unused
 
 // EventTailerSpec defines the desired state of EventTailer
 type EventTailerSpec struct {

pkg/sdk/extensions/api/v1alpha1/hosttailer_types.go

@@ -26,12 +26,12 @@ import (
 
 // +name:"HostTailer"
 // +weight:"200"
-type _hugoHostTailer = interface{} //nolint:deadcode,unused
+type _hugoHostTailer = any //nolint:deadcode,unused
 
 // +name:"HostTailer"
 // +version:"v1alpha1"
 // +description:"HostTailer's main goal is to tail custom files and transmit their changes to stdout. This way the logging-operator is able to process them."
-type _metaHostTailer = interface{} //nolint:deadcode,unused
+type _metaHostTailer = any //nolint:deadcode,unused
 
 // HostTailerSpec defines the desired state of HostTailer
 type HostTailerSpec struct {

pkg/sdk/extensions/extensionsconfig/config_test.go

@@ -96,7 +96,6 @@ func TestFluentBitConfigFilePath(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			if got := fluentBitConfigFilePath(tt.args.image, tt.args.filePath); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("FluentBitConfigFilePath() = %v, want %v", got, tt.want)

pkg/sdk/logging/api/v1alpha1/clusterflow_types.go

@@ -22,12 +22,12 @@ import (
 
 // +name:"ClusterFlow"
 // +weight:"200"
-type _hugoClusterFlow interface{} //nolint:deadcode,unused
+type _hugoClusterFlow any //nolint:deadcode,unused
 
 // +name:"ClusterFlow"
 // +version:"v1alpha1"
 // +description:"ClusterFlow is the Schema for the clusterflows API"
-type _metaClusterFlow interface{} //nolint:deadcode,unused
+type _metaClusterFlow any //nolint:deadcode,unused
 
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:categories=logging-all

pkg/sdk/logging/api/v1alpha1/clusteroutput_types.go

@@ -22,12 +22,12 @@ import (
 
 // +name:"ClusterOutput"
 // +weight:"200"
-type _hugoClusterOutput interface{} //nolint:deadcode,unused
+type _hugoClusterOutput any //nolint:deadcode,unused
 
 // +name:"ClusterOutput"
 // +version:"v1alpha1"
 // +description:"ClusterOutput is the Schema for the clusteroutputs API"
-type _metaClusterOutput interface{} //nolint:deadcode,unused
+type _metaClusterOutput any //nolint:deadcode,unused
 
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:categories=logging-all

pkg/sdk/logging/api/v1alpha1/output_types.go

@@ -22,12 +22,12 @@ import (
 
 // +name:"OutputSpec"
 // +weight:"200"
-type _hugoOutputSpec interface{} //nolint:deadcode,unused
+type _hugoOutputSpec any //nolint:deadcode,unused
 
 // +name:"OutputSpec"
 // +version:"v1alpha1"
 // +description:"OutputSpec defines the desired state of Output"
-type _metaOutputSpec interface{} //nolint:deadcode,unused
+type _metaOutputSpec any //nolint:deadcode,unused
 
 // OutputSpec defines the desired state of Output
 type OutputSpec struct {

pkg/sdk/logging/api/v1beta1/clusterflow_types.go

@@ -20,12 +20,12 @@ import (
 
 // +name:"ClusterFlow"
 // +weight:"200"
-type _hugoClusterFlow interface{} //nolint:deadcode,unused
+type _hugoClusterFlow any //nolint:deadcode,unused
 
 // +name:"ClusterFlow"
 // +version:"v1beta1"
 // +description:"ClusterFlow is the Schema for the clusterflows API"
-type _metaClusterFlow interface{} //nolint:deadcode,unused
+type _metaClusterFlow any //nolint:deadcode,unused
 
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:categories=logging-all