Commit 9543d7e
feat: update the placement v1 with PR and CPRS (#544)
* update the placement v1 with PR and CPRS
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* update the placement v1 with PR and CPRS
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix the test now that we aded per cluster resource index
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix: address code review issues in placement v1 API types
- Add CEL immutability validations to CRP Spec (matching v1beta1):
policy cannot be removed once set, statusReportingScope immutable,
placementType immutable, and namespace selector requirement when
StatusReportingScope=NamespaceAccessible
- Fix contradictory +kubebuilder:validation:Required + omitempty on
ClusterResourcePlacementStatus fields (PlacementStatus, LastUpdatedTime)
- Add missing +kubebuilder:object:root=true to ResourcePlacementList
and ClusterResourcePlacementStatusList
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* fix: pin goimports to v0.42.0 and make envelope work de-duplication resilient
Two CI fixes:
1. Makefile: pin GOIMPORTS_VER from 'latest' to v0.42.0.
golang.org/x/tools v0.43.0 (latest) now requires Go >= 1.25.0, but
CI runs Go 1.24.13, causing the unit-and-integration-tests job to
fail at setup with:
go: golang.org/x/tools/cmd/goimports@latest: requires go >= 1.25.0
2. pkg/controllers/workgenerator/envelope.go: when multiple work objects
are found for the same envelope (possible transiently if the same CRP
name is reused quickly after deletion), self-heal by deleting all but
the most recently created work and proceeding, instead of returning an
UnexpectedBehaviorError that causes WorkSynchronized=False on the
binding. The previous hard-fail path caused e2e test flakiness in the
'mixed availability statefulset' case where cluster-1's workgenerator
would encounter leftover work objects from the prior test context.
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
* feat: address PR #484 review feedback
Remove deprecated ConfigMapEnvelopeType from v1 API, drop duplicate ResourcePlacement* condition types in favor of shorter variants, add CEL validation for placement type immutability on Policy field, and fix envelope duplicate work test to match self-healing behavior.
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
* Addressing feedback and adding some missing properties
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
* Address further feedback
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
---------
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Co-authored-by: Ryan Zhang <yangzhangrice@hotmail.com>
Co-authored-by: ryanzhang-oss <ryanzhang-oss@users.noreply.github.com>1 parent 2520bb6 commit 9543d7e
11 files changed
Lines changed: 3003 additions & 803 deletions
File tree
- apis/placement/v1
- config/crd/bases
- test/e2e
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
0 commit comments