Skip to content

Commit 0093e54

Browse files
committed
review: use the test-dashboard command from test_service.sh
Signed-off-by: Kimonas Sotirchos <[email protected]>
1 parent ea7e9e4 commit 0093e54

File tree

2 files changed

+10
-36
lines changed

2 files changed

+10
-36
lines changed

.github/workflows/central_dashboard_integration_test.yaml

Lines changed: 10 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ on:
33
pull_request:
44
paths:
55
- components/centraldashboard/**
6-
- components/access-management/**
7-
- components/profile-controller/**
6+
- components/access-management/**
7+
- components/profile-controller/**
88
- releasing/version/VERSION
99
- .github/workflows/central_dashboard_integration_test.yaml
1010
branches:
@@ -82,19 +82,19 @@ jobs:
8282
- name: Create Test Profile for Dashboard Testing
8383
run: |
8484
kubectl apply -f components/profile-controller/integration/resources/profile-dashboard-test.yaml
85-
85+
8686
for i in {1..60}; do
8787
if kubectl get namespace test-dashboard-profile >/dev/null 2>&1; then
8888
break
8989
fi
9090
echo "Waiting for namespace... (attempt $i/60)"
9191
sleep 5
9292
done
93-
93+
9494
if ! kubectl get namespace test-dashboard-profile >/dev/null 2>&1; then
9595
exit 1
9696
fi
97-
97+
9898
kubectl get profile test-dashboard-profile
9999
kubectl get namespace test-dashboard-profile
100100
@@ -110,46 +110,24 @@ jobs:
110110
run: |
111111
./testing/shared/test_service.sh test-health dashboard kubeflow 8082
112112
113-
- name: Test Dashboard Web Interface
113+
- name: Integration Tests
114114
run: |
115-
curl -f "http://localhost:8082/" >/dev/null 2>&1
116-
117-
curl -f "http://localhost:8082/healthz" >/dev/null 2>&1
118-
119-
RESPONSE=$(curl -s "http://localhost:8082/" | head -c 100)
120-
if [[ -n "$RESPONSE" ]]; then
121-
echo "Dashboard is serving content: ${RESPONSE:0:50}..."
122-
else
123-
exit 1
124-
fi
125-
126115
kubectl get service dashboard -n kubeflow
127116
kubectl get pods -n kubeflow -l app=dashboard
128-
129-
- name: Test Dashboard Performance
130-
run: |
117+
./testing/shared/test_service.sh test-dashboard dashboard kubeflow 8082
131118
./testing/shared/test_service.sh performance-test dashboard kubeflow 8082 80 10
132-
133-
- name: Test Dashboard Metrics
134-
run: |
135119
./testing/shared/test_service.sh test-metrics dashboard kubeflow 8082
136-
137-
- name: Check Dashboard Logs
138-
run: |
139120
./testing/shared/test_service.sh check-logs dashboard kubeflow 50
140-
141-
- name: Check for Errors in Logs
142-
run: |
143121
./testing/shared/test_service.sh check-errors dashboard kubeflow
144122
145123
- name: Test Dashboard Configuration
146124
run: |
147-
kubectl get configmap dashboard-config -n kubeflow
148-
kubectl describe configmap dashboard-config -n kubeflow
125+
kubectl get configmap dashboard-config -n kubeflow
126+
kubectl describe configmap dashboard-config -n kubeflow
149127
150128
- name: Test Virtual Service (if Istio is configured)
151129
run: |
152-
kubectl get virtualservice dashboard -n kubeflow
130+
kubectl get virtualservice dashboard -n kubeflow
153131
154132
- name: Stop Port Forward
155133
run: |

testing/shared/test_service.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ case "$OPERATION" in
3434
"test-dashboard")
3535
curl -f "http://localhost:${PORT}/" >/dev/null 2>&1
3636
curl -f "http://localhost:${PORT}/assets/dashboard.js" >/dev/null 2>&1
37-
curl -f "http://localhost:${PORT}/api/v1/namespaces" >/dev/null 2>&1
38-
curl -L "http://localhost:${PORT}/jupyter" >/dev/null 2>&1
39-
curl -L "http://localhost:${PORT}/pipeline" >/dev/null 2>&1
40-
curl -L "http://localhost:${PORT}/katib" >/dev/null 2>&1
4137
# test communication between dashboard and access-management
4238
curl -f \
4339
-H "kubeflow-userid: test-user" \

0 commit comments

Comments
 (0)