Skip to content

Commit 1960d4d

Browse files
committed
feat: sanitize cluster admin list in NewKfamClient
1 parent c4fbfc4 commit 1960d4d

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

components/access-management/kfam/api_default.go

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
"net/url"
1717
"path"
1818
"strconv"
19+
"strings"
1920
"time"
2021

2122
profileRegister "github.com/kubeflow/kubeflow/components/access-management/pkg/apis/kubeflow/v1beta1"
@@ -83,12 +84,23 @@ func NewKfamClient(userIdHeader string, userIdPrefix string, clusterAdmins []str
8384
kubeClient: kubeClient,
8485
roleBindingLister: roleBindingLister,
8586
},
86-
clusterAdmins: clusterAdmins,
87+
clusterAdmins: sanitizeClusterAdmins(clusterAdmins),
8788
userIdHeader: userIdHeader,
8889
userIdPrefix: userIdPrefix,
8990
}, nil
9091
}
9192

93+
func sanitizeClusterAdmins(clusterAdmins []string) []string {
94+
var sanitized []string
95+
for _, admin := range clusterAdmins {
96+
trimmed := strings.TrimSpace(admin)
97+
if trimmed != "" {
98+
sanitized = append(sanitized, trimmed)
99+
}
100+
}
101+
return sanitized
102+
}
103+
92104
func getRESTClient(group string, version string) (*rest.RESTClient, error) {
93105
restconfig, err := config.GetConfig()
94106
if err != nil {

0 commit comments

Comments
 (0)