Skip to content

Commit 1be323a

Browse files
committed
Updated the validate-webhook function to use the correct mutating webhook configuration name
Signed-off-by: kunal-511 <[email protected]>
1 parent 189b964 commit 1be323a

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

.github/workflows/poddefaults_intergration_test.yaml

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -52,27 +52,13 @@ jobs:
5252

5353
- name: Deploy PodDefaults Webhook Component
5454
run: |
55-
cd components/admission-webhook
56-
57-
if [ -f "Makefile" ]; then
58-
if grep -q "docker-build-multi-arch" Makefile; then
59-
make docker-build-multi-arch IMG="${IMG}" TAG="${TAG}"
60-
else
61-
make docker-build IMG="${IMG}" TAG="${TAG}"
62-
fi
63-
fi
64-
65-
kind load docker-image "${IMG}:${TAG}"
66-
67-
cd manifests
68-
export CURRENT_IMAGE="${IMG}"
69-
export PR_IMAGE="${IMG}:${TAG}"
70-
export CURRENT_IMAGE_ESCAPED=$(echo "$CURRENT_IMAGE" | sed 's|\.|\\.|g')
71-
export PR_IMAGE_ESCAPED=$(echo "$PR_IMAGE" | sed 's|\.|\\.|g')
72-
73-
kustomize build overlays/cert-manager \
74-
| sed "s|${CURRENT_IMAGE_ESCAPED}:[a-zA-Z0-9_.-]*|${PR_IMAGE_ESCAPED}|g" \
75-
| kubectl apply -f -
55+
./testing/gh-actions/deploy_component.sh \
56+
"admission-webhook" \
57+
"components/admission-webhook" \
58+
"${IMG}" \
59+
"${TAG}" \
60+
"manifests" \
61+
"overlays/cert-manager"
7662
7763
- name: Wait for Admission Webhook to be Ready
7864
run: |

testing/gh-actions/test_poddefault.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ EOF
123123
"validate-webhook")
124124
kubectl get crd poddefaults.kubeflow.org
125125
kubectl describe crd poddefaults.kubeflow.org
126-
kubectl get mutatingwebhookconfiguration poddefaults.kubeflow.org
127-
kubectl describe mutatingwebhookconfiguration poddefaults.kubeflow.org
126+
kubectl get mutatingwebhookconfiguration admission-webhook-mutating-webhook-configuration
127+
kubectl describe mutatingwebhookconfiguration admission-webhook-mutating-webhook-configuration
128128
;;
129129

130130
"cleanup")

0 commit comments

Comments
 (0)