Skip to content

Commit 5047c38

Browse files
committed
feat: add test for ensuring dashboard to KFAM communication
Signed-off-by: Kimonas Sotirchos <[email protected]>
1 parent 843d968 commit 5047c38

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

testing/shared/test_service.sh

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ case "$OPERATION" in
2222
"stop-port-forward")
2323
if [ -f "/tmp/portforward_${SERVICE_NAME}_${PORT}.pid" ]; then
2424
PF_PID=$(cat /tmp/portforward_${SERVICE_NAME}_${PORT}.pid)
25-
kill "${PF_PID}"
25+
kill "${PF_PID}"
2626
rm -f /tmp/portforward_${SERVICE_NAME}_${PORT}.pid
2727
fi
2828
;;
@@ -33,24 +33,29 @@ case "$OPERATION" in
3333

3434
"test-dashboard")
3535
curl -f "http://localhost:${PORT}/" >/dev/null 2>&1
36-
curl -f "http://localhost:${PORT}/assets/dashboard.js" >/dev/null 2>&1
37-
curl -f "http://localhost:${PORT}/api/v1/namespaces" >/dev/null 2>&1
38-
curl -L "http://localhost:${PORT}/jupyter" >/dev/null 2>&1
39-
curl -L "http://localhost:${PORT}/pipeline" >/dev/null 2>&1
40-
curl -L "http://localhost:${PORT}/katib" >/dev/null 2>&1
36+
curl -f "http://localhost:${PORT}/assets/dashboard.js" >/dev/null 2>&1
37+
curl -f "http://localhost:${PORT}/api/v1/namespaces" >/dev/null 2>&1
38+
curl -L "http://localhost:${PORT}/jupyter" >/dev/null 2>&1
39+
curl -L "http://localhost:${PORT}/pipeline" >/dev/null 2>&1
40+
curl -L "http://localhost:${PORT}/katib" >/dev/null 2>&1
41+
# test communication between dashboard and access-management
42+
curl -f \
43+
-H "kubeflow-userid: test-user" \
44+
"http://localhost:${PORT}/api/workgroup/exists" \
45+
>/dev/null 2>&1
4146
;;
4247

4348
"test-kfam")
4449
curl -f "http://localhost:${PORT}/healthz" >/dev/null 2>&1
45-
curl "http://localhost:${PORT}/version" 2>/dev/null
50+
curl "http://localhost:${PORT}/version" 2>/dev/null
4651
;;
4752

4853
"test-api-with-user")
4954
USER_EMAIL="${6:-test-user@example.com}"
5055
PROFILE_NAMESPACE="${7:-test-profile}"
5156
curl -H "kubeflow-userid: ${USER_EMAIL}" \
5257
"http://localhost:${PORT}/kfam/v1/bindings?namespace=${PROFILE_NAMESPACE}" \
53-
2>/dev/null
58+
2>/dev/null
5459
;;
5560

5661
"performance-test")
@@ -62,7 +67,7 @@ case "$OPERATION" in
6267
;;
6368

6469
"test-metrics")
65-
curl "http://localhost:${PORT}/metrics" 2>/dev/null
70+
curl "http://localhost:${PORT}/metrics" 2>/dev/null
6671
;;
6772

6873
"validate-service")
@@ -94,4 +99,4 @@ case "$OPERATION" in
9499
echo "Valid operations: port-forward, stop-port-forward, test-health, test-dashboard, test-kfam, test-api-with-user, performance-test, test-metrics, validate-service, check-logs, check-errors"
95100
exit 1
96101
;;
97-
esac
102+
esac

0 commit comments

Comments
 (0)