Skip to content

Commit 5cf0e01

Browse files
committed
review: explanation of dashboard overlay
Signed-off-by: Kimonas Sotirchos <[email protected]>
1 parent be7d1cf commit 5cf0e01

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,12 @@ perform the following actions:
6666
./scripts/upgrade_v1_to_v2.sh
6767
```
6868

69+
> **NOTE**: The script will use the `overlays/kserve` for the Dashboard, since this is what was also used by the 1.10.2 manifests
70+
> [`[1]`](https://github.com/kubeflow/manifests/blob/v1.10.2/example/kustomization.yaml#L74)
71+
> [`[2]`](https://github.com/kubeflow/manifests/blob/v1.10.2/applications/centraldashboard/overlays/oauth2-proxy/kustomization.yaml#L6).
72+
> This means that the dashboard will have a link to the models web app, and expects it to be deployed. If this is not the case for your cluster, you should instead deploy
73+
> the dashboard using the `overlays/istio` overlay.
74+
6975
## Community
7076

7177
Kubeflow Dashboard is part of the Kubeflow project, refer to the [Kubeflow Community](https://www.kubeflow.org/docs/about/community/) page for more information.

scripts/upgrade_v1_to_v2.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ echo -e "Successfully applied the Profile Controller component!"
8383
echo -e "\nApplying Dashboard component..."
8484
echo -e "--------------------------------"
8585
kustomize build \
86-
$SCRIPT_DIR/../components/centraldashboard/manifests/overlays/istio \
86+
$SCRIPT_DIR/../components/centraldashboard/manifests/overlays/kserve \
8787
| kubectl apply -f -
8888

8989
echo "Waiting for Dashboard Deployment to become available..."

0 commit comments

Comments
 (0)