Dashboard UI links are broken when inspect volume

[beliaev-maksim]

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Dashboard UI links are broken when inspect volume

Steps:

1. Open Volumes
2. Pick a volume associated to the notebook
3. Click on the name of the Notebook in pods mounted section
4. Click back button

You are landed on the Notebooks page, while sidebar navigation is still on Volumes. URL corresponds to the Notebook page.

5. Click on Volumes
   You see that URL changed, UI not
6. Now if you refresh the page it is finally Volumes

I am afraid it is a bug behind another bug.

I also recorded the video, see below.

What did you expect to happen:
when click back button go to Volume details

Environment:

• Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): 1.7.0

simplescreenrecorder-2023-03-29_15.30.49.mp4

[andreyvelich]

/transfer dashboard

[google-oss-prow]

@beliaev-maksim: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Dashboard UI links are broken when inspect volume

Steps:

1. Open Volumes
2. Pick a volume associated to the notebook
3. Click on the name of the Notebook in pods mounted section
4. Click back button

You are landed on the Notebooks page, while sidebar navigation is still on Volumes. URL corresponds to the Notebook page.

5. Click on Volumes
   You see that URL changed, UI not
6. Now if you refresh the page it is finally Volumes

I am afraid it is a bug behind another bug.

I also recorded the video, see below.

What did you expect to happen:
when click back button go to Volume details

Environment:

• Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): 1.7.0

simplescreenrecorder-2023-03-29_15.30.49.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had recent activity.

Members may comment /reopen to reopen it.

[thesuperzapper]

This is still valid, and is caused by the internal iframe changing path, and not correctly propagating to the outer document.

/reopen

[google-oss-prow]

@thesuperzapper: Reopened this issue.

Details

In response to this:

This is still valid, and is caused by the internal iframe changing path, and not correctly propagating to the outer document.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hahahannes]

A short summary of the steps and the actual vs expected parent frame URL, active sidebar menu items and if the UI shows the correct frame

Step	Actual URL	Expected URL	Actual Active Sidebar	Expected Active Sidebar	Correct UI loaded
1. Open Volumes	/volumes	/volumes	Volumes	Volumes	Yes
2. Pick a volume associated to the notebook	/volumes	/volumes	Volumes	Volumes	Yes
3. Click on the name of the Notebook in pods mounted section	/volumes	/notebooks	Volumes	Notebooks	yes
4. Click back button	/notebooks	\notebooks	Volumes	Notebooks	yes
5. Click on Volumes	/volumes	/volumes	Volumes	Volumes	no
6. refresh the page	/volumes	/volumes	Volumes	Volumes	yes

[hahahannes]

The PR fixes one bug marked in bold in the table below:

Step	Actual URL	Expected URL	Actual Active Sidebar	Expected Active Sidebar	Correct UI loaded
1. Open Volumes	/volumes	/volumes	Volumes	Volumes	Yes
2. Pick a volume associated to the notebook	/volumes	/volumes	Volumes	Volumes	Yes
3. Click on the name of the Notebook in pods mounted section	/notebooks	/notebooks	Volumes	Notebooks	yes
4. Click back button	/notebooks	/notebooks	Volumes	Notebooks	yes
5. Click on Volumes	/volumes	/volumes	Volumes	Volumes	no
6. refresh the page	/volumes	/volumes	Volumes	Volumes	yes

kubeflow-ui-iframe-sync.webm

I assume their are two more bugs:

1. Active item in the sidebar not being updated when the iframe changes (Step 3 and 4). It seems that the main-page.js _routePageChanged and therefore the _setActiveMenuLink method is not called. I found a fix now for this.

2. iFrame does not change even though the parent iframe URL changes (Step Nr. 5) I was hoping that the PR would fix that one as well. It seems that clicking an already active link does not trigger the main-page.js _routePageChanged method and there not the _setIframeSrc methods

[juliusvonkohout]

CC also @kimwnasptd