fix: double URL encoding in central-dashboard links #6564
Conversation
google-oss-prow
bot
requested review from
elikatsis,
SachinVarghese and
StefanoFioravanzo
Central dashboard would lead to double URL encoding characters such as quotation due to the expectation that the underlying Iron-Location hash is already decoded, and failure to decode it when directly setting it from an iframe URL change. Fixes #6563
timcharper
force-pushed
the
tharper/upstream-fix-double-escaping
branch
from
097113e to
42c6844
Compare
|
Can you join the next notebooks WG meeting in two weeks ? We are always looking for help. https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes. You can also reach us on slack in the channel wg-notebooks and wg-manifests. |
thesuperzapper
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
The Kubeflow Dashboard code has been migrated to the new repo, please re-open PR at: https://github.com/kubeflow/dashboard
/close
|
@andreyvelich: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Central dashboard would lead to double URL encoding characters such as quotation due to the expectation that the
underlying Iron-Location hash is already decoded, and failure to decode it when directly setting it from an iframe URL
change.
Fixes kubeflow/dashboard#34